Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: add httplib2 #2881

Merged
merged 1 commit into from
Mar 2, 2022
Merged

ansible: add httplib2 #2881

merged 1 commit into from
Mar 2, 2022

Conversation

richardlau
Copy link
Member

V8's gclient.py now requires httplib2. Install it on all the
machines that the V8 CI can run on.

Fixes: #2880

@richardlau
Copy link
Member Author

This proved to be very tricky on the RHEL 7 s390x (LinuxONE) instances. httplib2 refused to install via pip2 with the following error:

$ sudo pip2 install httplib2
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Collecting httplib2
  Using cached httplib2-0.20.4.tar.gz (349 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: /bin/python /usr/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpbgjji9
       cwd: /tmp/pip-install-JBiOqF/httplib2
  Complete output (4 lines):
  Traceback (most recent call last):
    File "/usr/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py", line 15, in <module>
      from glob import glob
  ImportError: No module named glob
  ----------------------------------------
ERROR: Command errored out with exit status 1: /bin/python /usr/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpbgjji9 Check the logs for full command output.

I even tried sudo pip2 install glob2 (which some searches suggested to install for glob) but still got the above error. In the end I had to disable PEP 517 (--no-use-pep517) but I had to pick an older version of httplib2 because the later ones require PEP 517.

And to cap everything off the adoptopenjdk tasks were failing due to a mismatched checksum on the downloaded binary compared to the metadata from the AdoptOpenJDK REST API. I've switched the RHEL7 s390x instances back to the java-1.8.0-openjdk yum package. I also registered the RHEL 7 instances with our RHEL subscription so that we get the most up to date packages.

Comment on lines -144 to -153
# Required for V8 builds
- name: rhel8 | update python package alternatives
community.general.alternatives:
link: /usr/bin/python
name: python
path: /usr/bin/python2
when:
- os == "rhel8"
- build_test_v8|default(False)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to ansible/roles/build-test-v8/tasks/partials/rhel8.yml.

Comment on lines -147 to -150
rhel8_s390x: [
'GConf2-devel,python2' # Needed for V8 builds
],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to ansible/roles/build-test-v8/tasks/partials/rhel8.yml.

@targos
Copy link
Member

targos commented Mar 2, 2022

This proved to be very tricky on the RHEL 7 s390x (LinuxONE) instances. httplib2 refused to install via pip2

Maybe the tools are now able to run with Python 3?

@richardlau
Copy link
Member Author

This proved to be very tricky on the RHEL 7 s390x (LinuxONE) instances. httplib2 refused to install via pip2

Maybe the tools are now able to run with Python 3?

We'd still need to be able to run the job against older Node.js release lines.

V8's `gclient.py` now requires `httplib2`. Install it on all the
machines that the V8 CI can run on.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit c5cdd41 into nodejs:master Mar 2, 2022
@richardlau richardlau deleted the httplib2 branch March 2, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken job node-test-commit-v8-linux?
3 participants