Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote: add expected assets for Nodejs 18 #2922

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

richardlau
Copy link
Member

This is in two commits:

cc @nodejs/releasers @nodejs/platform-windows @nodejs/build

Temporarily remove 32-bit Windows assets from the expected assets for
Node.js 18 until we have an updated stable V8 version that builds
successfully on 32-bit Windows.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit e7a0053 into nodejs:master Apr 13, 2022
@richardlau richardlau deleted the nodejs18 branch April 13, 2022 11:58
@richardlau
Copy link
Member Author

Added /home/staging/tools/promote/expected_assets/v18.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants