Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: use explicit tap2junit version #3272

Merged
merged 2 commits into from
Apr 3, 2023
Merged

ansible: use explicit tap2junit version #3272

merged 2 commits into from
Apr 3, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Mar 30, 2023 •
edited
Loading

Fixes: #3268
Fixes: nodejs/node#47048

@MoLow MoLow requested a review from richardlau March 30, 2023 16:24
@MoLow
Copy link
Member Author

MoLow commented Mar 30, 2023

@richardlau I have tested this using ansible-playbook ansible/playbooks/jenkins/worker/create.yml --limit "test-rackspace-debian10-x64-1" --start-at-task "prepare installing tap2junit" -vv

is there a good way to stop after this task?

@MoLow
Copy link
Member Author

MoLow commented Mar 30, 2023

I am using --step

@richardlau
Copy link
Member

@richardlau I have tested this using ansible-playbook ansible/playbooks/jenkins/worker/create.yml --limit "test-rackspace-debian10-x64-1" --start-at-task "prepare installing tap2junit" -vv

is there a good way to stop after this task?

I'm not aware of one.

mhdawson
mhdawson approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MoLow
Copy link
Member Author

MoLow commented Mar 30, 2023 •
edited
Loading

upgraded:

  • windows
  • freebsd
  • macos, macos10
  • smartos
  • ubuntu

@MoLow MoLow force-pushed the use-explicit-tap2junit-version branch 2 times, most recently from 1e2c113 to 81b5fb6 Compare March 30, 2023 22:49
@richardlau
Copy link
Member

@MoLow I'm wondering if the Python pip error in https://ci.nodejs.org/job/node-test-linter/49235/console is related to the changes in this PR. It ran on test-ibm-ubuntu1804-x64-1.

00:25:23 + make lint-py-build PYTHON=python3
00:25:24 Pip installing flake8 linter on Python 3.8.0...
00:25:24 python3 -m pip install --no-user --upgrade -t tools/pip/site-packages flake8 || \
00:25:24 	python3 -m pip install --no-user --upgrade --system -t tools/pip/site-packages flake8
00:25:26 
00:25:26 Usage:   
00:25:26   /usr/bin/python3 -m pip install [options] <requirement specifier> [package-index-options] ...
00:25:26   /usr/bin/python3 -m pip install [options] -r <requirements file> [package-index-options] ...
00:25:26   /usr/bin/python3 -m pip install [options] [-e] <vcs project url> ...
00:25:26   /usr/bin/python3 -m pip install [options] [-e] <local project path> ...
00:25:26   /usr/bin/python3 -m pip install [options] <archive url/path> ...
00:25:26 
00:25:26 no such option: --no-user
00:25:27 
00:25:27 Usage:   
00:25:27   /usr/bin/python3 -m pip install [options] <requirement specifier> [package-index-options] ...
00:25:27   /usr/bin/python3 -m pip install [options] -r <requirements file> [package-index-options] ...
00:25:27   /usr/bin/python3 -m pip install [options] [-e] <vcs project url> ...
00:25:27   /usr/bin/python3 -m pip install [options] [-e] <local project path> ...
00:25:27   /usr/bin/python3 -m pip install [options] <archive url/path> ...
00:25:27 
00:25:27 no such option: --no-user
00:25:27 Makefile:1520: recipe for target 'lint-py-build' failed

@MoLow MoLow force-pushed the use-explicit-tap2junit-version branch from 81b5fb6 to 51d43fd Compare March 31, 2023 04:41
@MoLow
Copy link
Member Author

MoLow commented Mar 31, 2023 •
edited
Loading

@richardlau I changed the ubuntu script and the linter is now fixed (https://ci.nodejs.org/job/node-test-linter/49246/)
however I had some trouble updating the python version on aix

@MoLow MoLow mentioned this pull request Mar 31, 2023
Closed
@cclauss
Copy link
Contributor

cclauss commented Mar 31, 2023

Where is the --no-user option that caused #3273 ?

Why is #3273 closed if this PR that fixes it is still open?

A --no-user option was added to pip 5 years ago but was later removed.

@MoLow
Copy link
Member Author

MoLow commented Mar 31, 2023

Where is the --no-user option that caused #3273 ?

https://github.com/nodejs/node/blob/main/Makefile#L1521-L1522

Why is #3273 closed if this PR that fixes it is still open?

the fix was deployed manually

@MoLow MoLow force-pushed the use-explicit-tap2junit-version branch from 51d43fd to e0775f3 Compare March 31, 2023 12:29
@MoLow MoLow force-pushed the use-explicit-tap2junit-version branch from e0775f3 to ebc4c17 Compare March 31, 2023 12:37
@richardlau
Copy link
Member

@richardlau I changed the ubuntu script and the linter is now fixed (https://ci.nodejs.org/job/node-test-linter/49246/) however I had some trouble updating the python version on aix

Did you sort out the issue on AIX? If not, what are you seeing?

@MoLow
Copy link
Member Author

MoLow commented Apr 2, 2023

Did you sort out the issue on AIX? If not, what are you seeing?

I am not able to install python > 3.6, see https://ci.nodejs.org/job/node-test-commit-aix/
it seems that AIX is the only platform not yet using the latest version of tap2junit and causing the build to not bee "green"

@MoLow MoLow mentioned this pull request Apr 2, 2023
Closed
@MoLow
Copy link
Member Author

MoLow commented Apr 3, 2023

@richardlau I'v pushed another commit and AIX seems green now https://ci.nodejs.org/job/node-test-commit-aix/
can you please re-approve?

@MoLow MoLow requested a review from richardlau April 3, 2023 14:33
@MoLow MoLow merged commit 38342fd into nodejs:main Apr 3, 2023
@MoLow MoLow deleted the use-explicit-tap2junit-version branch April 3, 2023 14:37
@richardlau richardlau mentioned this pull request Apr 4, 2023
Closed
targos pushed a commit to targos/nodejs-build that referenced this pull request Apr 7, 2023
@MoLow @targos
ansible: use explicit tap2junit version (nodejs#3272)
a7b1ba5 
* ansible: use explicit tap2junit version

* ansible: install python 3.9 on aix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tap2junit needs to be updated tap2junit failing to parse non-ASCII characters
4 participants
@MoLow @richardlau @cclauss @mhdawson