Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins,doc: remove support for building addons with VS2017 #3603

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

targos
Copy link
Member

@targos targos commented Jan 3, 2024

This is necessary for C++20 compat.

Refs: nodejs/node#45427

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@targos targos merged commit 172558b into nodejs:main Jan 8, 2024
1 check passed
@targos targos deleted the c++20-final-change branch January 8, 2024 10:37
StefanStojanovic added a commit to JaneaSystems/node-gyp that referenced this pull request Jan 15, 2024
Drop VS2017 support for Node.js v22 and above.

Refs: nodejs/build#3603
Refs: nodejs/node#45427
StefanStojanovic added a commit to JaneaSystems/node-gyp that referenced this pull request Jan 15, 2024
Drop VS2017 support for Node.js v22 and above.

Refs: nodejs/build#3603
Refs: nodejs/node#45427
StefanStojanovic added a commit to JaneaSystems/node-gyp that referenced this pull request Jan 16, 2024
Drop VS2017 support for Node.js v22 and above.

Refs: nodejs/build#3603
Refs: nodejs/node#45427
StefanStojanovic added a commit to JaneaSystems/node-gyp that referenced this pull request Jan 30, 2024
Drop VS2017 support for Node.js v22 and above.

Refs: nodejs/build#3603
Refs: nodejs/node#45427
StefanStojanovic added a commit to JaneaSystems/node-gyp that referenced this pull request Feb 1, 2024
Drop VS2017 support for Node.js v22 and above.

Refs: nodejs/build#3603
Refs: nodejs/node#45427
StefanStojanovic added a commit to JaneaSystems/node-gyp that referenced this pull request Feb 10, 2024
Drop VS2017 support for Node.js v22 and above.

Refs: nodejs/build#3603
Refs: nodejs/node#45427
StefanStojanovic added a commit to nodejs/node-gyp that referenced this pull request Mar 6, 2024
Drop VS2017 support for Node.js v22 and above.

Refs: nodejs/build#3603
Refs: nodejs/node#45427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants