chore(deps): bump semver from 7.6.2 to 7.6.3 #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bugfix version of semver includes significant performance improvements that I guess we would like to see in corepack. See: npm/node-semver#726
aduh95
approved these changes
Jul 18, 2024
| @@ -33,7 +33,7 @@ | |||
| "esbuild": "^0.21.0", | |||
| "eslint": "^8.57.0", | |||
| "proxy-from-env": "^1.1.0", | |||
| "semver": "^7.5.2", | |||
| "semver": "^7.6.3", | |||
There was a problem hiding this comment.
I'm more in the camp of "We shouldn't touch package.json for minor updates" (fewer chances of git conflicts, and smaller diffs is always nicer to review), but no strong feelings
Suggested change
| "semver": "^7.6.3", | |
| "semver": "^7.5.2", |
There was a problem hiding this comment.
I would generally agree, if dependencies are bumped mainly for the sake of... bumping them. In this case, the bump is very intentional, and we SPECIFICALLY want 7.6.3 or later. Then, you can backtrack why want 7.6.3 and not earlier versions more easily, because there's a trace of it in git blame. Sure, there's git blame of the lockfile, but that's hardly a human-readable format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix version of semver includes significant performance improvements that I guess we would like to see in corepack.
See: npm/node-semver#726