Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access for Richard Lau #335

Closed
Trott opened this issue Aug 24, 2022 · 5 comments
Closed

Access for Richard Lau #335

Trott opened this issue Aug 24, 2022 · 5 comments

Comments

@Trott
Copy link
Member

Trott commented Aug 24, 2022

Richard Lau (@richardlau) does not apparently have access to the relevant secrets for the GitHub bot. Let's add him, please?

@nodejs/github-bot @nodejs/build

@richardlau
Copy link
Member

I've had previous private discussions with @mhdawson (I think around the time we were renaming the branches from master->main) and we thought that probably everyone in @nodejs/build-infra probably ought to have access to all the secrets (including the github-bot) in the secrets repo.

@phillipj
Copy link
Member

Sounds good to me 👍🏻

The list of people having access to those secrets would benefit from being revisited, that goes for the @nodejs/github-bot team too.

@Trott
Copy link
Member Author

Trott commented Aug 25, 2022

The list of people having access to those secrets would benefit from being revisited, that goes for the @nodejs/github-bot team too.

I've gone ahead and removed maclover7 and williamkapke as they have both been absent from the core project for years, as far as I know. If there are others to be removed, let me know here or (if you prefer) privately. (My email is in my GitHub profile.)

If Richard wants to add himself to the team, he is an org owner and can do it himself, so I'll leave that alone either way.

@sxa
Copy link
Member

sxa commented Feb 8, 2023

From build WG meeting: @rvagg has access and will add the access for Richard

@richardlau
Copy link
Member

Now sorted 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants