Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: execvp: printf: Argument list too long #147

Merged
merged 3 commits into from
May 11, 2022

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented May 6, 2022

@cclauss
Copy link
Contributor

cclauss commented May 6, 2022

Please run psf/black on the code so that the Python tests pass.

@gengjiawen

This comment was marked as outdated.

@targos
Copy link
Member

targos commented May 11, 2022

Could we split the changes into one commit for each file and more meaningful messages?

For __init__.py I suggested in #149 (comment):

feat: add `PRODUCT_DIR_ABS` variable

With ideally some text that explains the purpose of the new variable.

For ninja.py:

chore: use GiB unit in comments

For make.py: not sure I understand all the changes enough to suggest something.

@gengjiawen
Copy link
Member Author

Could we split the changes into one commit for each file and more meaningful messages?

For __init__.py I suggested in #149 (comment):

feat: add `PRODUCT_DIR_ABS` variable

With ideally some text that explains the purpose of the new variable.

For ninja.py:

chore: use GiB unit in comments

For make.py: not sure I understand all the changes enough to suggest something.

I have created #152 and #151, I will leave this for make when the other two merged.

@gengjiawen gengjiawen changed the title fix: sync Node.js upstream change fix execvp: printf: Argument list too long May 11, 2022
@gengjiawen gengjiawen changed the title fix execvp: printf: Argument list too long fix: execvp: printf: Argument list too long May 11, 2022
@gengjiawen
Copy link
Member Author

@danbev Not sure the commit msg is accure, PTAL.

@danbev
Copy link

danbev commented May 11, 2022

@danbev Not sure the commit msg is accure, PTAL.

That looks good to me 👍

@gengjiawen gengjiawen merged commit c4e14f3 into nodejs:main May 11, 2022
@gengjiawen gengjiawen deleted the fix/sync branch May 11, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants