Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gyp: use LDFLAGS_host for host toolset #98

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Feb 19, 2021

This makes the behaviour similar to that of CFLAGS_host

This makes the behaviour similar to that of CFLAGS_host
@targos
Copy link
Member

targos commented Feb 19, 2021

I think this could break setups that expect the current behavior? Should we maybe fall back to it if LDFLAGS_host is not set?

@isuruf
Copy link
Contributor Author

isuruf commented Feb 19, 2021

I'm not a fan of that as LDFLAGS might contain flags like -L<prefix>/lib to find dependent libraries and they are intended for target and not host. In that case having an empty set of flags for cross compiling is better. This matches the behaviour of CFLAGS_host. If you feel strongly about it, I can change it to fallback to LDFLAGS.

@targos
Copy link
Member

targos commented Feb 20, 2021

Interesting. I searched for LDFLAGS_host and found this: https://chromium.googlesource.com/external/gyp/+/c6f471687407bf28ddfc63f1a8f47aeb7bf54edc%5E%21/#F2

I don't know why we do not have the change in our copy of gyp, but does it make sense to also change the makefile generator like they did?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants