Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

html and css juice cleanse #30

Closed
wants to merge 7 commits into from
Closed

html and css juice cleanse #30

wants to merge 7 commits into from

Conversation

zeke
Copy link
Contributor

@zeke zeke commented Jan 13, 2015

This is based on existing work from #27.

  • less markup
  • cleaner CSS
  • type sizing with rems
  • decent on mobile
  • color scheme based on @rvagg's 1.0.0 release logo

index

screen shot 2015-01-12 at 11 03 03 pm

faq

screen shot 2015-01-12 at 11 21 52 pm

index on mobile

screen shot 2015-01-12 at 11 36 12 pm

faq on mobile

screen shot 2015-01-12 at 11 36 03 pm

@rvagg
Copy link
Member

rvagg commented Jan 13, 2015

beautiful

@zeke
Copy link
Contributor Author

zeke commented Jan 13, 2015

thanks @rvagg! working on bringing it up to date with the latest 1.0.0 branch.

@zeke
Copy link
Contributor Author

zeke commented Jan 13, 2015

screen shot 2015-01-13 at 12 26 18 am

@zeke
Copy link
Contributor Author

zeke commented Jan 13, 2015

This is perusable at https://iojs-homepage.herokuapp.com/

@zeke zeke mentioned this pull request Jan 13, 2015
9 tasks
@chrisdickinson
Copy link

Great work! Would it be possible to include a link to the docs in the nav bar? Also, this might be silly of me to ask, but should we consider adding the twitter card info so we can display the logo in tweets that link the website?

@rvagg
Copy link
Member

rvagg commented Jan 13, 2015

I'll be symlinking the latest release api docs at iojs.org/api/ so you can use that for now

@rvagg
Copy link
Member

rvagg commented Jan 13, 2015

also the download link needs to go to iojs.org/dist/v1.0.0/ (i.e. without the "download" bit in it)

@rvagg
Copy link
Member

rvagg commented Jan 13, 2015

(I know you're not responsible for all of these nits I'm picking up, but you're awake and working on this!)

on the ES6 page, the command to find v8 version can be shortened to just iojs -pe process.versions.v8

@Fishrock123
Copy link
Contributor

I like it, this way we can also re-use the version card for past versions. My only question is: isn't the top bar a little empty then?

@mikeal
Copy link
Contributor

mikeal commented Jan 13, 2015

Love it!

Maybe cut the top bar for a few weeks until we have more pages/content?

On Tuesday, January 13, 2015, Jeremiah Senkpiel notifications@github.com
wrote:

I like it, this way we can also re-use the version card for past versions.
My only question is: isn't the top bar a little empty then?


Reply to this email directly or view it on GitHub
#30 (comment).

@shuhblam
Copy link

this looks amazing, i agree with cutting the top bar until there is some full nav

@zeke
Copy link
Contributor Author

zeke commented Jan 13, 2015

Glad you're liking it. :)

The top bar "io.js" link is currently the only way to get to the homepage. I could add a home link to the footer, but mainly I added the top bar to get the page some visual weight. I can experiment with it.

Would anyone be opposed to me converting this to a harp app with a build step, or should I keep trudging through the redundancy?

@Fishrock123
Copy link
Contributor

@zeke can you try a rebase onto 1.0.0? If it fails all over don't worry about it I'll take care of it.

@Fishrock123
Copy link
Contributor

@zeke I'd prefer something.. simpler? I don't really understand what harp all does.

@zeke
Copy link
Contributor Author

zeke commented Jan 13, 2015

@Fishrock123 rebase attempts are pretty messy.

Harp is pretty simple and has nice conventions. A harp app would look something like this:

_layout.jade
styles.styl
index.jade
es6.markdown
docs.html
other.whatever

npm start would run harp server, which includes a watcher and hosts files on port 9000.

npm run build would run harp compile [options] [projectPath] [outputPath] which converts all the preprocessory files into their html/css/js equivalents.

@Fishrock123
Copy link
Contributor

@zeke Yeah, i might have to just leave all this be, I didn't realize your 1.0.0 patch was a merge commit. :S

@zeke
Copy link
Contributor Author

zeke commented Jan 13, 2015

Sorry @Fishrock123, I suck at the gits. I can give it another try...

@Fishrock123
Copy link
Contributor

@zeke doesn't matter too much now, I'm just using this branch. Between the up-merge, the rebase, and etc, things became... an "octopus merge" to quote @bnoordhuis haha

It's fine. Updating 1.0.0 in a moment based on this and doing a couple minor things, linking docs, etc.

@zeke
Copy link
Contributor Author

zeke commented Jan 13, 2015

Okay @Fishrock123 I "fixed" the conflicts and this is ready for merge again. Want to merge it into 1.0.0 so I don't keep diverging so badly?

@Fishrock123
Copy link
Contributor

It's technically merged in, I'll close this when I close the other issue. (If you want to add to this, just delete your branch and pull down 1.0.0 again.. sorry for the trouble.)

What can we do about a docs link? I was thinking of putting it in the header, but that would mean we have nav in two spots..

@zeke
Copy link
Contributor Author

zeke commented Jan 13, 2015

Sounds good. I'll scrap this branch and work off 1.0.0 again.

Why not just add the docs link to the footer nav?

@zeke zeke closed this Jan 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants