Tweak CI walk filter order #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
reviewed
Mar 23, 2019
| @@ -238,23 +236,25 @@ const FAILURE_FILTERS = [{ | |||
| }, { | |||
| filter(ctx, text) { | |||
| const patterns = [{ | |||
| pattern: /FATAL: .+/g, | |||
| context: { index: -1, contextBefore: 0, contextAfter: 5 } | |||
| pattern: /There is not enough space in the file system./g, | |||
There was a problem hiding this comment.
The ones moved here are actually more specific? Can you split those instead?
There was a problem hiding this comment.
Yeah I wrote this patch on GitHub, hoping I hit it in one try ¯\(ツ)/¯
I need to dig into this locally a bit more...
|
Ping @refack |
|
This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved more specific pattern higher up