Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimatch to latest version #966

Closed
TDA opened this issue Jun 21, 2016 · 2 comments
Closed

Update minimatch to latest version #966

TDA opened this issue Jun 21, 2016 · 2 comments

Comments

@TDA
Copy link

TDA commented Jun 21, 2016

From NSP, https://nodesecurity.io/advisories/118, we need to update minimatch. This is affecting a lot of repos upstream.
I am ready to put in a PR if you guys are ok with it :)
TDA added a commit to TDA/node-gyp that referenced this issue Jun 21, 2016
@TDA
chore(minimatch): update minimatch version
5af666d 
Fixes nodejs#966
@TDA TDA mentioned this issue Jun 21, 2016
Closed
@rvagg
Copy link
Member

rvagg commented Jun 27, 2016

fixed in #961

@rvagg rvagg closed this as completed Jun 27, 2016
@TDA
Copy link
Author

TDA commented Jun 27, 2016

@rvagg Thank you, can you also publish it to npm with an updated version? :) Cuz the NSP warning is still displayed if I do an npm i node-gyp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TDA @rvagg