Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin,lib: remove extra comments/lines/spaces #1508

Merged
merged 2 commits into from
Jul 28, 2018
Merged

bin,lib: remove extra comments/lines/spaces #1508

merged 2 commits into from
Jul 28, 2018

Conversation

maclover7
Copy link
Contributor

Checklist
  • npm install && npm test passes
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
  • Removes "module dependencies" comments and things that, IMHO, don't add
    too much value. Happy to add back if helps some people when reading
    through node-gyp.
  • DRY up lib/process-release.js.
  • Removes a bunch of extra blank lines, as well as random spaces.

- Removes "module dependencies" comments and things that, IMHO, don't add
too much value. Happy to add back if helps some people when reading
through `node-gyp`.
- DRY up `lib/process-release.js`.
- Removes a bunch of extra blank lines, as well as random spaces.
@maclover7
Copy link
Contributor Author

@@ -126,7 +118,6 @@ process.on('uncaughtException', function (err) {
})

function errorMessage () {
// copied from npm's lib/util/error-handler.js
Copy link
Member

@richardlau richardlau Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sort of an attribution (although the current path in npm now appears to be lib/utils/error-handler.js), so maybe keep?

@maclover7
Copy link
Contributor Author

updated @richardlau, PTAL

@maclover7
Copy link
Contributor Author

@maclover7 maclover7 merged commit 6b0f4ae into nodejs:master Jul 28, 2018
@maclover7 maclover7 deleted the jm-rm-extra branch July 28, 2018 03:36
@maclover7
Copy link
Contributor Author

Landed in 6b0f4ae, thank you for the review!

rvagg pushed a commit that referenced this pull request Apr 24, 2019
- Removes "module dependencies" comments and things that, IMHO, don't add
too much value. Happy to add back if helps some people when reading
through `node-gyp`.
- DRY up `lib/process-release.js`.
- Removes a bunch of extra blank lines, as well as random spaces.

PR-URL: #1508
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg rvagg mentioned this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants