Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v5.0.2 #1792

Closed
wants to merge 1 commit into from
Closed

Release proposal: v5.0.2 #1792

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 21, 2019

Maybe next week and the changelog is likely to change prior to release (will update this OP if it does).

  • [2761afbf73] - build,test: add duplicate symbol test (Gabriel Schulhof) #1689
  • [82f129d6de] - gyp: replace optparse to argparse (KiYugadgeter) #1591
  • [afaaa29c61] - gyp: remove from __future__ import with_statement (cclauss) #1799
  • [a991f633d6] - gyp: fix the remaining Python 3 issues (cclauss) #1793
  • [f952b08f84] - gyp: move from __future__ import to the top of the file (cclauss) #1789
  • [4f4a677dfa] - gyp: use different default compiler for z/OS (Shuowang (Wayne) Zhang) #1768
  • [03683f09d6] - lib: code de-duplication (Pavel Medvedev) #965
  • [611bc3c89f] - lib: add .json suffix for explicit require (Rod Vagg) #1787
  • [d3478d7b0b] - meta: add to .gitignore (Refael Ackermann) #1573
  • [7dd7f2b2a2] - test: fix Python syntax error in test-adding.js (cclauss) #1793
  • [395f843de0] - test: replace self-signed cert with 'localhost' (Rod Vagg) #1795
  • [a52c6eb9e8] - test: migrate from tape to tap (Rod Vagg) #1795
  • [ec2eb44a30] - test: use Nan in duplicate_symbols (Gabriel Schulhof) #1689
  • [1597c84aad] - test: use Travis CI to run tests on every pull request (cclauss) #1752
  • [dd9bf929ac] - zos: update compiler options (Shuowang (Wayne) Zhang) #1768

@richardlau
Copy link
Member

@rvagg rvagg mentioned this pull request Jun 22, 2019
@rvagg
Copy link
Member Author

rvagg commented Jun 26, 2019

rebased with latest, updated OP with new commit list.

https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/134/

I might get this out in the next day or two. Then once it's out I'd like to merge #1794 which introduces more rigorous linting but shuffles a lot of code in the process, making merging and rebasing more difficult. Beyond that I'd also like to do some general refactoring, more code shuffling, to aid with maintainability. I just don't want to make existing PRs more difficult to land so it'd be nice to get some more things merged before I do that.

@cclauss
Copy link
Contributor

cclauss commented Jun 26, 2019

This is a nice milestone because with 189 days until Python 2 end of life, we are "syntax compatible" with Python 3. That does not mean that the port to Python 3 is complete but it does allow for experimentation. Thanks team!

@rvagg rvagg closed this Jun 27, 2019
@rvagg rvagg deleted the rvagg/5.0.2-proposal branch June 27, 2019 01:43
@rvagg
Copy link
Member Author

rvagg commented Jun 27, 2019

released, also included 7a9a038 'test: add parallel test runs on macOS and Windows'

@joaocgreis
Copy link
Member

@rvagg shouldn't this be published in npm?

@rvagg
Copy link
Member Author

rvagg commented Jul 3, 2019

Yes, it should be, but it's not. I'm sure I published it! I have a fixed workflow for publishes. Maybe it errored during 2fa or something and I didn't notice cause I was in robot mode.

I've done a release now and it went through fine. Thanks for picking this up @joaocgreis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants