v5.0.3 proposal #1829
Closed
v5.0.3 proposal #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think #1829 is our problem and we don't have a PR for #1826 yet. There's a little urgency to this release because we broke ecosystem things with 2761afb, see nodejs/node#28647 (comment), so I'd like to get this out sooner than later. 5.0.2 made it into an npm release unfortunately so it'd be nice to catch the next update with a new 5.0.3. |
richardlau
approved these changes
Jul 16, 2019
|
published, two commits were reordered, I'll note in their PRs what the new hashes are |
This was referenced Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal for a patch release once #1828 is merged. This drops #1811 because it's a semver-major. What I'd like to do is rebase master on top of this once the release is out to avoid (defer?) creating a branch to manage this. It will change the hash of that commit and #1828 when it lands. If anyone objects to this then I guess we can go ahead and make a
v5.xbranch, I'd just prefer to not add that level of complication while we don't need it.66ad305775] - python: accept Python 3 conditionally (João Reis) #18157e7fce3fed] - python: move Python detection to its own file (João Reis) #1815e40c99e283] - src: implement standard.js linting (Rod Vagg) #1794bb92c761a9] - test: add Node.js 6 on Windows to Travis CI (João Reis) #18127fd924079f] - test: increase tap timeout (João Reis) #18127e8127068f] - test: cover supported node versions with travis (Rod Vagg) #180924109148df] - test: downgrade to tap@^12 for continued Node 6 support (Rod Vagg) #1808656117cc4a] - win: make VS path match case-insensitive (João Reis) #1806