Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "is" when comparing to None #1860

Closed
wants to merge 1 commit into from

Conversation

MrMebelMan
Copy link
Contributor

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Do not use the comparison operator == when checking if an object is None.
https://www.python.org/dev/peps/pep-0008/#programming-recommendations

@cclauss cclauss added the Python label Aug 19, 2019
rvagg pushed a commit that referenced this pull request Aug 20, 2019
PR-URL: #1860
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <r@va.gg>
@rvagg
Copy link
Member

rvagg commented Aug 20, 2019

landed in a301abc

@rvagg rvagg closed this Aug 20, 2019
@rvagg rvagg mentioned this pull request Sep 26, 2019
rvagg pushed a commit that referenced this pull request Sep 26, 2019
PR-URL: #1860
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <r@va.gg>
@rvagg rvagg mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants