Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify XcodeVersion() to convert "4.2" to "0420" and "10.0" to "1000" #1895

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 26, 2019

nodejs/node-addon-api#445 (comment)

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly gibberish to me but I tried this construct in both python2 and python3 REPLs and it does as advertised!

rvagg pushed a commit that referenced this pull request Sep 27, 2019
@rvagg
Copy link
Member

rvagg commented Sep 27, 2019

landed in 8e9ec3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants