travis: add Windows + Python 3.8 to the mix #1921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please feel free to pull in the Linux changes from #1923 if that helps. |
4 tasks
joaocgreis
pushed a commit
that referenced
this pull request
Oct 16, 2019
PR-URL: #1921 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>
|
CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/165/ Landed in 5a83630. Took the liberty to fast-track this to clear Travis, let me know if there's any issue. |
rvagg
added a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #1921 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Python 3 tests are currently failing in travis because choco has switched
pythonto 3.8 but we're setting the PATH for 3.7. So I've fixed the 3.7 tests to the last 3.7 version and introduced a 3.8 test for Windows.Python 3.8 isn't currently available on the other platforms, easily anyway, so they're not added in this.