Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix/fix error handling #1925

Closed
wants to merge 7 commits into from
Closed

Bug fix/fix error handling #1925

wants to merge 7 commits into from

Commits on Oct 16, 2019

  1. sys.stderr.write(p_stderr) with python 3 errors out with: `TypeError:… 

    … write() argument must be str, not bytes`.

It seems to me that its unneccesary, and it should simply throw the exception instead.
    @dothebart
    dothebart committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    439a8e8 View commit details
    Browse the repository at this point in the history

  2. It seems python 3 doesn't linke None as a parameter here, it will t… 

    …hrow: `Exception: 'NoneType' object is not subscriptable`.
    @dothebart
    dothebart committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    25c6a69 View commit details
    Browse the repository at this point in the history

  3. properly encode strings before handing them over to hashlib.sha

    @dothebart
    dothebart committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    19012c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. fix encoding as sugested by @cclaus

    @dothebart
    dothebart committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    34dcfad View commit details
    Browse the repository at this point in the history

  2. as seen in GYP3 this seems to be the solution here too

    @dothebart
    dothebart committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    b695898 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. Revert the addition of a blank line

    @cclauss
    cclauss committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    15a0ded View commit details
    Browse the repository at this point in the history

  2. Revert stderr.decode("utf-8") that was landed in nodejs#1937 

    nodejs#1937
    @cclauss
    cclauss committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    cea42a4 View commit details
    Browse the repository at this point in the history