node-gyp@5.1.0 Release Proposal #2012
Conversation
Republish of v5.0.6 but with node-gyp-v5.0.6.tar.gz removed from pack file PR-URL: #1972
PR-URL: #1971 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #1985 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Running Python standalone tests on multiple OSes would free up Travis CI for tests of various combinations of Node.js and Python as well as tests on other [CPU architectures](https://docs.travis-ci.com/user/multi-cpu-architectures). __arch: amd64, arm64, ppc64le, s390x__ PR-URL: #1985 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reorder Travis builds by OS. Replace `pyenv global` calls with properly set `PATH` and `PYENV_VERSION` env vars. Does not assume python modules are in the `PATH` so all python modules are prefixed with `python -m`. PR-URL: #1979 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #1978 Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #2001 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #1996 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #1992 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #1993 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #1994 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
I’m okay with any of the three options but I do wonder how much in the wild exposure 6.x gets since it isn’t used by npm. |
|
@rvagg was about to ask you if the no proxy support was making it to v5 (I see that it is) In order to be used at our company it will need to get to node at some point and the only way is through npm which uses v5 :( |
|
@imatlopez yep, it'll go in, I just want it to bake in the wild in v6 first. That's been out for a couple of days but we should give it a couple of weeks at least to be sure (similar practice in Node.js itself for backporting is a couple of months, minimum). We have to be more careful shipping potentially breaking features in v5 since it's got a significantly larger userbase (also I don't want to be personally responsible for people screaming at npm). |
I have quite a few instances of VS installed and it looks like Find-VisualStudio.cs enumerates all of them, even when find-visualstudio.js already knows which one it wants (from the environment variable in the developer command prompt). One of them (from 15.7.2, if that's interesting) causes a COMException on the ISetupInstance2.GetPackages call. Ignoring such packages seems harmless and unblocks the rest of the run. PR-URL: #2018 Reviewed-By: João Reis <reis@janeasystems.com>
|
Speak up now if you have anything that should hold up a release. Synced with master, updated OP and prepared package.json and CHANGELOG.md for a release tomorrow. This puts v5 roughly in sync (minus semver-major) with v6.1.0 but also adds #2018 because that seems pretty safe and has been waiting for a new v6 release. For the record, this is the diff with master:
|
|
published v5.1.0 |
f37a8b40d0] - doc: add GitHub Actions badge (doc: add GitHub Actions badge #1994) (Rod Vagg) #1994cb3f6aae5e] - doc: update macOS_Catalina.md (doc: update macOS_Catalina.md #1992) (James Home) #19920607596a4c] - doc: fix typo in README.md (Fix typo in README.md #1985) (Suraneti Rodsuwan) #19850d5a415a14] - doc: add travis badge (Rod Vagg) #1971103740cd95] - gyp: list(dict) so we can del dict(key) while iterating (Christian Clauss) #2009278dcddbdd] - lib: ignore VS instances that cause COMExceptions (Andrew Casey) #20181694907bbf] - lib: compatibility with semver ≥ 7 (newfor semver.Range) (Xavier Guimard) #2006a3f1143514] - (SEMVER-MINOR) lib: noproxy support, match proxy detection torequest(Matias Lopez) #197852365819c7] - test: remove old docker test harness (test: remove old docker test harness #1993) (Rod Vagg) #1993bc509c511d] - test: add Windows to GitHub Actions testing (test: GitHub Actions add Windows to the testing #1996) (Christian Clauss) #199691ee26dd48] - test: fix typo in header download test (test: fix typo in header download test #2001) (Richard Lau) #20010923f344c9] - test: direct python invocation & simpler pyenv (Matias Lopez) #197932c8744b34] - test: fix macOS Travis on Python 2.7 & 3.7 (Christian Clauss) #1979fd4b1351e4] - test: initial Github Actions with Ubuntu & macOS (Christian Clauss) #1985This is mainly a backlog flushing exercise, as you can see, almost everything is docs or test, but there is also #1978 which hasn't yet been released on
masterso the choice is:Will opt for 1 at the moment, it's mainly just interesting to see what the diff is. Feel free to weigh in.