Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

debugger: also exit when the repl emits 'exit' #5637

Closed
wants to merge 1 commit into from
Closed

debugger: also exit when the repl emits 'exit' #5637

wants to merge 1 commit into from

Conversation

fb55
Copy link

@fb55 fb55 commented Jun 7, 2013

Fixes #5631

@bnoordhuis
Copy link
Member

/cc @TooTallNate

@trevnorris trevnorris mentioned this pull request Dec 6, 2013
Closed
@Raynos
Copy link

Raynos commented Dec 26, 2014

👍 This will help with a wrapper around the node debugger that I'm writing.

cjihrig
cjihrig reviewed Dec 29, 2014
View reviewed changes
lib/_debugger.js
}

// Exit debug repl on Ctrl + C
this.repl.rli.on('SIGINT', exitDebugRepl);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use once() instead of on() so that you don't need to worry about removing the listener?

@cjihrig
Copy link

cjihrig commented Dec 29, 2014

Ah, nevermind, using on() is fine here. LGTM

@jasnell
Copy link
Member

jasnell commented Aug 13, 2015

@cjihrig ... this is targeted at master. Do we want to push this off to nodejs/node or get this landed in v0.12?

@cjihrig
Copy link

cjihrig commented Aug 13, 2015

@jasnell let's take it to nodejs/node.

@jasnell
Copy link
Member

jasnell commented Aug 13, 2015

@fb55... I know it's been a while, but are you willing to update this and open it against master in http://github.com/nodejs/node?

@jasnell jasnell self-assigned this Aug 13, 2015
@fb55 fb55 mentioned this pull request Aug 13, 2015
Closed
@fb55
Copy link
Author

fb55 commented Aug 13, 2015

@jasnell /done

@jasnell
Copy link
Member

jasnell commented Aug 13, 2015

Thanks!

@jasnell jasnell closed this Aug 13, 2015
jasnell pushed a commit to nodejs/node that referenced this pull request Nov 16, 2015
@fb55 @jasnell
debugger: also exit when the repl emits 'exit'
a95eb5c 
Exit the debug repl when repl emits 'exit'

Refs: nodejs/node-v0.x-archive#5637
Fixes: nodejs/node-v0.x-archive#5631
PR-URL: #2369
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit to nodejs/node that referenced this pull request Nov 17, 2015
@fb55 @Fishrock123
debugger: also exit when the repl emits 'exit'
66dccaf 
Exit the debug repl when repl emits 'exit'

Refs: nodejs/node-v0.x-archive#5637
Fixes: nodejs/node-v0.x-archive#5631
PR-URL: #2369
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Dec 29, 2015
@fb55
debugger: also exit when the repl emits 'exit'
d10b710 
Exit the debug repl when repl emits 'exit'

Refs: nodejs/node-v0.x-archive#5637
Fixes: nodejs/node-v0.x-archive#5631
PR-URL: #2369
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Jan 19, 2016
@fb55
debugger: also exit when the repl emits 'exit'
31b4091 
Exit the debug repl when repl emits 'exit'

Refs: nodejs/node-v0.x-archive#5637
Fixes: nodejs/node-v0.x-archive#5631
PR-URL: #2369
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jasnell jasnell

Labels
debugger master pr repl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fb55 @bnoordhuis @Raynos @cjihrig @jasnell