This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Upgrade libuv to 1.0.0-rc2 #8566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, sorry for the mess with uv_cwd :-( |
|
LGTM |
It was modified in libuv to be consistent with uv_exepath and not include the trailing NULL byte in the returned size.
|
@indutny this should now be ready to go. I also upgraded the bundled libuv, since I was there. |
|
LGTM |
|
Any reason this hasn't landed yet? |
|
I don't have the commit bit, so it's up to you folks :-) IIRC @indutny On Wed, Nov 5, 2014 at 6:44 AM, Trevor Norris notifications@github.com
/Saúl |
trevnorris
pushed a commit
that referenced
this pull request
Nov 6, 2014
PR-URL: #8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris
pushed a commit
that referenced
this pull request
Nov 6, 2014
PR-URL: #8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris
pushed a commit
that referenced
this pull request
Nov 6, 2014
It was modified in libuv to be consistent with uv_exepath and not include the trailing NULL byte in the returned size. PR-URL: #8566 Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just pulled latest libuv v1.x into node and these are the required fixes to make node happy again.
libuv 1.0.0-rc2 will be released soon, once it's pulled into node these fixes need to be applied.
R=@indutny, @trevnorris ?