Fix icutrim when building small-icu on Big-Endian platforms

nodejs · Aug 28, 2015 · 1135ad0 · 1135ad0
1 parent c6a54d0
commit 1135ad0
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/tools/icu/icu-generic.gyp b/tools/icu/icu-generic.gyp
@@ -29,9 +29,17 @@
       'type': 'none',
       'toolsets': [ 'host', 'target' ],
       'direct_dependent_settings': {
+        'conditions': [
+          [ 'icu_endianness == "l"', {
+             'defines': [
+                # ICU cannot swap the initial data without this. 
+                # http://bugs.icu-project.org/trac/ticket/11046 
+                'UCONFIG_NO_LEGACY_CONVERSION=1',
+                'UCONFIG_NO_IDNA=1',
+             ],
+          }],
+        ], 
         'defines': [
-          'UCONFIG_NO_LEGACY_CONVERSION=1',
-          'UCONFIG_NO_IDNA=1',
           'UCONFIG_NO_TRANSLITERATION=1',
           'UCONFIG_NO_SERVICE=1',
           'UCONFIG_NO_REGULAR_EXPRESSIONS=1',