Skip to content

Commit

Permalink
test: replace common port with specific number
Browse files Browse the repository at this point in the history
PR-URL: #40344
Fixes: #40336
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
  • Loading branch information
watilde authored and targos committed Oct 13, 2021
1 parent 4564a93 commit 1e15137
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-net-connect-options-invalid.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
const common = require('../common');
require('../common');
const assert = require('assert');
const net = require('net');

Expand All @@ -11,7 +11,7 @@ const net = require('net');
];
invalidKeys.forEach((invalidKey) => {
const option = {
...common.localhostIPv4,
port: 8080,
[invalidKey]: true
};
const message = `The property 'options.${invalidKey}' is not supported. Received true`;
Expand Down
3 changes: 1 addition & 2 deletions test/parallel/test-socket-options-invalid.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
const common = require('../common');
require('../common');
const assert = require('assert');
const net = require('net');

Expand All @@ -11,7 +11,6 @@ const net = require('net');
];
invalidKeys.forEach((invalidKey) => {
const option = {
...common.localhostIPv4,
[invalidKey]: true
};
const message = `The property 'options.${invalidKey}' is not supported. Received true`;
Expand Down

0 comments on commit 1e15137

Please sign in to comment.