Skip to content

Commit

Permalink
doc: fix release guide example consistency
Browse files Browse the repository at this point in the history
This changeset fixes two consistency issues in this single example that
guides releasers on how to push the tag to the remote repo.

The first issue is that the remote git reference is consistently
referred as `upstream` elsewhere in the guide.

The second issue being that the version example used in the rest of the
guide should be a fictional `v1.2.3` as stated in the "How to create a
release" guide notes:

>  * Examples will use the fictional release version `1.2.3`.

PR-URL: #44385
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
ruyadorno authored and RafaelGSS committed Sep 5, 2022
1 parent 7f16177 commit 21437f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doc/contributing/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ haven't pushed your tag first, then build promotion won't work properly.
Push the tag using the following command:

```console
$ git push <remote> <vx.y.z>
$ git push upstream v1.2.3
```

_Note_: Please do not push the tag unless you are ready to complete the
Expand Down

0 comments on commit 21437f7

Please sign in to comment.