http: add debug message for invalid header value

This makes it easier to see what header has an invalid value.
nodejs · Oct 24, 2016 · 6930512 · 6930512
1 parent 5532a7a
commit 6930512
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -317,6 +317,7 @@ function storeHeader(self, state, field, value) {
       'Header name must be a valid HTTP Token ["' + field + '"]');
   }
   if (common._checkInvalidHeaderChar(value) === true) {
+    debug('Header "%s" contains invalid characters', field);
     throw new TypeError('The header content contains invalid characters');
   }
   state.messageHeader += field + ': ' + escapeHeaderValue(value) + CRLF;
@@ -357,6 +358,7 @@ OutgoingMessage.prototype.setHeader = function setHeader(name, value) {
   if (this._header)
     throw new Error('Can\'t set headers after they are sent.');
   if (common._checkInvalidHeaderChar(value) === true) {
+    debug('Header "%s" contains invalid characters', name);
     throw new TypeError('The header content contains invalid characters');
   }
   if (this._headers === null)
@@ -534,6 +536,7 @@ OutgoingMessage.prototype.addTrailers = function addTrailers(headers) {
         'Trailer name must be a valid HTTP Token ["' + field + '"]');
     }
     if (common._checkInvalidHeaderChar(value) === true) {
+      debug('Trailer "%s" contains invalid characters', field);
       throw new TypeError('The trailer content contains invalid characters');
     }
     this._trailer += field + ': ' + escapeHeaderValue(value) + CRLF;