Skip to content

Commit

Permalink
test: performance, remove Popen(shell=True) on Win
Browse files Browse the repository at this point in the history
not needed according to official python docs -
https://docs.python.org/2/library/subprocess.html#index-2

PR-URL: #12138
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
refack authored and MylesBorins committed Apr 18, 2017
1 parent 20c38eb commit 9520762
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,6 @@ def RunProcess(context, timeout, args, **rest):
pty_out = rest.pop('pty_out')

process = subprocess.Popen(
shell = utils.IsWindows(),
args = popen_args,
**rest
)
Expand Down

0 comments on commit 9520762

Please sign in to comment.