Skip to content

Commit

Permalink
src: organize imports in inspector_profiler.cc
Browse files Browse the repository at this point in the history
In the other .cc files in the project, includes are in alphabetical
order, with local files first, and libraries after. However,
inspector_profiler.cc has a library declared in the middle of the import
order, and v8 is the second to last being imported, instead of the last.
So I reordered the imports and testing showed no side effects;
everything passed.

PR-URL: #29073
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
  • Loading branch information
DTeachs authored and targos committed Aug 19, 2019
1 parent 13a4979 commit b2936cf
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/inspector_profiler.cc
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
#include "inspector_profiler.h"
#include <sstream>
#include "base_object-inl.h"
#include "debug_utils.h"
#include "diagnosticfilename-inl.h"
#include "memory_tracker-inl.h"
#include "node_file.h"
#include "node_internals.h"
#include "v8-inspector.h"
#include "util-inl.h"
#include "v8-inspector.h"

#include <sstream>

namespace node {
namespace profiler {
Expand Down Expand Up @@ -323,7 +324,7 @@ void EndStartedProfilers(Environment* env) {
std::string GetCwd(Environment* env) {
char cwd[PATH_MAX_BYTES];
size_t size = PATH_MAX_BYTES;
int err = uv_cwd(cwd, &size);
const int err = uv_cwd(cwd, &size);

if (err == 0) {
CHECK_GT(size, 0);
Expand Down

0 comments on commit b2936cf

Please sign in to comment.