Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: repeated slashes in file URL should be arranged #11188

Closed
watilde opened this issue Feb 6, 2017 · 2 comments
Closed

url: repeated slashes in file URL should be arranged #11188

watilde opened this issue Feb 6, 2017 · 2 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@watilde
Copy link
Member

watilde commented Feb 6, 2017

In the http scheme, the slashes after the colon are brought together in two, but it seems that it remains as it is in the file scheme.

const URL = require('url').URL

new URL('http://////example.com').href
//  =>  'http://example.com/'

new URL('file://////foo/bar').href
//  =>  'file://////foo/bar'
// it should be `file:///foo/bar`

Issue report on the spec: whatwg/url#232

@jasnell jasnell added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Feb 6, 2017
@jasnell
Copy link
Member

jasnell commented Feb 6, 2017

Will keep an eye on the whatwg/url issue. If that gets fixed upstream we will get it fixed here.

@watilde
Copy link
Member Author

watilde commented Mar 29, 2017

Spec is landed:tada:, but let's wait to start implementation till #12058 get a merge since it potentially makes some conflicts in test/src. I'm gonna work on it.

watilde added a commit to watilde/node that referenced this issue Apr 8, 2017
It should trim the slashes after the colon into three for file URL.

Refs: web-platform-tests/wpt#5195
Fixes: nodejs#11188
TimothyGu pushed a commit to TimothyGu/node that referenced this issue Apr 25, 2017
It should trim the slashes after the colon into three for file URL.

PR-URL: nodejs#12507
Refs: web-platform-tests/wpt#5195
Fixes: nodejs#11188
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue May 1, 2017
It should trim the slashes after the colon into three for file URL.

PR-URL: #12507
Refs: web-platform-tests/wpt#5195
Fixes: #11188
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

No branches or pull requests

2 participants