-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net.Socket.prototype.connect is having TypeError when called without connectionListener #11761
Comments
Amazing. I'm having this same issue after upgrading to the latest version of node and trying to run my application through pm2. I'll be watching closely. Thank you in advance! |
@tc-mccarthy yes. i was experiencing same thing with pm2 and try to figure out what is the problem. fyi, for now i came up with downgrading node to 7.7.1 |
@vhain not really a fix, but a workaround for me was downgrading to node v6.0.0. Things sprung back to life. |
/cc @joyeecheung |
Yeah..it's a bug due to the oversight of #11667, which assumes the options are always normalized but they are not, should've fixed the test coverage before refactoring them, sorry for the inconvenience & thanks for the fix! |
Yes I confirm that it's a bug. |
We are affected by the same issue. Current version is broken. We switched back to 7.7.1 and everything works again. |
I really appreciate the job you are doing and do not mean to introduce any hurry. There is any approximation on when we can expect a working current version? I would appreciate that information to decide if we should make fixes or wait. |
Arguments of Socket.prototype.connect should be also normalized, causing error when called without callback. Changed Socket.prototype.connect's code same as net.connect and added test. Fixes: nodejs#11761
@nodejs/release When is a 7.7.3 planned? This bug is reported to be present only in 7.7.2 (I have not verified this, but its been noticed reasonably widely) @fcanela the fix is almost approved for master, but I'm not sure when the next release is planned |
I'm having this same issue after upgrading to the latest version of node and trying to run my application through pm2. @vhain ,I use the node 7.7.1, It's work.thanks very much |
Arguments of Socket.prototype.connect should be also normalized, causing error when called without callback. Changed Socket.prototype.connect's code same as net.connect and added test. Fixes: nodejs#11761 PR-URL: nodejs#11762 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Arguments of Socket.prototype.connect should be also normalized, causing error when called without callback. Changed Socket.prototype.connect's code same as net.connect and added test. Fixes: nodejs#11761 PR-URL: nodejs#11762 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
net.Socket.prototype.connect
should work fine without callback (connectionListener) according to docbut it's working like this
related PR: #11667
The text was updated successfully, but these errors were encountered: