Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed test: parallel/test-tls-wrap-timeout #1200

Closed
jbergstroem opened this issue Mar 19, 2015 · 6 comments
Closed

failed test: parallel/test-tls-wrap-timeout #1200

jbergstroem opened this issue Mar 19, 2015 · 6 comments
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.

Comments

@jbergstroem
Copy link
Member

So, this test fails every now and then. First spotted it on the 32-bit FreeBSD buildbot. I've been able to reproduce it once every ten runs.

=== release test-tls-wrap-timeout ===
Path: parallel/test-tls-wrap-timeout
assert.js:87
  throw new assert.AssertionError({
        ^
AssertionError: undefined undefined undefined
    at Socket.g (events.js:257:16)
    at emitNone (events.js:67:13)
    at Socket.emit (events.js:163:7)
    at Socket._onTimeout (net.js:326:8)
    at Timer.unrefTimeout (timers.js:507:13)
Command: out/Release/iojs /usr/home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-freebsd101-32/test/parallel/test-tls-wrap-timeout.js

If I raise the socket timeout to 150 (currently 120) I can't reproduce.

@jbergstroem jbergstroem added test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Mar 19, 2015
@rvagg
Copy link
Member

rvagg commented Mar 19, 2015

/cc @indutny

@indutny
Copy link
Member

indutny commented Mar 19, 2015

Looking.

@indutny
Copy link
Member

indutny commented Mar 19, 2015

Gosh, guess it is just racey. I'll send a PR that will introduce bigger delays.

indutny added a commit to indutny/io.js that referenced this issue Mar 19, 2015
The test is timing dependent, ensure that it won't fail on the busy CI
boxes.

Fix: nodejs#1200
@indutny
Copy link
Member

indutny commented Mar 19, 2015

Should be fixed in #1201

indutny added a commit that referenced this issue Mar 19, 2015
The test is timing dependent, ensure that it won't fail on the busy CI
boxes.

Fix: #1200
PR-URL: #1201
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@indutny
Copy link
Member

indutny commented Mar 19, 2015

Assuming fixed as of 3038b8e

@indutny indutny closed this as completed Mar 19, 2015
@jbergstroem
Copy link
Member Author

Build going on here: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/337/

It's a dice roll, but yeah. Back to blue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants