Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base64 decoding drops characters when there is whitespace in the middle #13657

Closed
seishun opened this issue Jun 13, 2017 · 0 comments · Fixed by #13660
Closed

base64 decoding drops characters when there is whitespace in the middle #13657

seishun opened this issue Jun 13, 2017 · 0 comments · Fixed by #13660
Labels
buffer Issues and PRs related to the buffer subsystem.

Comments

@seishun
Copy link
Contributor

seishun commented Jun 13, 2017 •
edited
Loading

  • Version: 8.1.0 and master
  • Platform: all
  • Subsystem: buffer
console.log(Buffer.from(" YWJvcnVtLg", 'base64').toString());

expected:

aborum.

actual:

aborum

I suspect e77a83f. This is also the cause for #13636. cc @addaleax
@addaleax addaleax mentioned this issue Jun 13, 2017
Closed
3 tasks
@addaleax addaleax added the buffer Issues and PRs related to the buffer subsystem. label Jun 13, 2017
@seishun seishun mentioned this issue Jun 13, 2017
Merged
3 tasks
addaleax pushed a commit that referenced this issue Jun 17, 2017
@seishun @addaleax
src: fix decoding base64 with whitespace
07fcc14 
`max_i` should also include the characters that were just read by
`base64_decode_group_slow()`.

PR-URL: #13660
Fixes: #13636
Fixes: #13657
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this issue Jun 21, 2017
@seishun @addaleax
src: fix decoding base64 with whitespace
a27a35b 
`max_i` should also include the characters that were just read by
`base64_decode_group_slow()`.

PR-URL: #13660
Fixes: #13636
Fixes: #13657
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@chjj chjj mentioned this issue Feb 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: fix decoding base64 with whitespace
2 participants
@addaleax @seishun