deps/v8/src/compiler/graph-visualizer.h:23:1: error: 'FILE' does not name a type

[saper]

This is for 2.0.0, being built with g++ 4.8.4 on FreeBSD 8.4 (both amd64 and i386).
For other versions we are using clang which works fine.
.

  g++48 '-DV8_TARGET_ARCH_X64' '-DENABLE_DISASSEMBLER' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' -I../deps/v8  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -fno-strict-aliasing -I/usr/local/include -O3 -ffunction-sections -fdata-sections -fno-omit-frame-pointer -fdata-sections -ffunction-sections -O3 -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /wrkdirs/usr/ports/www/iojs44/work/io.js-2.0.0/out/Release/.deps//wrkdirs/usr/ports/www/iojs44/work/io.js-2.0.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/graph-visualizer.o.d.raw -O2 -pipe -fstack-protector -Wl,-rpath=/usr/local/lib/gcc48 -fno-strict-aliasing -Wl,-rpath=/usr/local/lib/gcc48 -c -o /wrkdirs/usr/ports/www/iojs44/work/io.js-2.0.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/graph-visualizer.o ../deps/v8/src/compiler/graph-visualizer.cc
In file included from ../deps/v8/src/compiler/graph-visualizer.cc:5:0:
../deps/v8/src/compiler/graph-visualizer.h:23:1: error: 'FILE' does not name a type
 FILE* OpenVisualizerLogFile(CompilationInfo* info, const char* phase,
 ^
deps/v8/tools/gyp/v8_base.target.mk:370: recipe for target '/wrkdirs/usr/ports/www/iojs44/work/io.js-2.0.0/out/Release/obj.target/v8_base/deps/v8/src/compiler/graph-visualizer.o' failed

[saper]

Upstream report: http://code.google.com/p/v8/issues/detail?id=4079

[bnoordhuis]

Does the build succeed when you apply this patch?

diff --git a/deps/v8/src/compiler/graph-visualizer.h b/deps/v8/src/compiler/graph-visualizer.h
index 17094c2..0e6a647 100644
--- a/deps/v8/src/compiler/graph-visualizer.h
+++ b/deps/v8/src/compiler/graph-visualizer.h
@@ -5,6 +5,7 @@
 #ifndef V8_COMPILER_GRAPH_VISUALIZER_H_
 #define V8_COMPILER_GRAPH_VISUALIZER_H_

+#include <stdio.h>
 #include <iosfwd>

 namespace v8 {

[saper]

Yes, it does. Figured out a moment ago :) Both amd64 and i386 build fine. Just playing with my setup to submit this back to v8...

[bnoordhuis]

Don't worry, I'll upload the patch. It's an arcane process you wouldn't believe...

[saper]

:) No worries. Did submit a patch to android and gerrit code review, it's actually almost the same...

[bnoordhuis]

Here's mine FWIW: https://codereview.chromium.org/1128053002/

[saper]

I actually wonder why it is FreeBSD specific?

[bnoordhuis]

I speculate that on most systems (but not FreebSD), iosfwd pulls in stdio.h (where FILE lives, or is supposed to live.)

[saper]

Yes, it includes <wchar.t> which does not include stdio. I wonder why clang doesn't mind then :)

[brendanashworth]

This should have been fixed in #1639, please reopen if you still have the issue.