Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated link in test-crypto-authenticated #17619

Closed
tniessen opened this issue Dec 11, 2017 · 1 comment
Closed

Outdated link in test-crypto-authenticated #17619

tniessen opened this issue Dec 11, 2017 · 1 comment
Labels
crypto Issues and PRs related to the crypto subsystem.

Comments

@tniessen
Copy link
Member

This reference in test-crypto-authenticated.js is outdated:

node/test/parallel/test-crypto-authenticated.js

Lines 72 to 73 in 2d2986a

// http://csrc.nist.gov/groups/ST/toolkit/BCM/documents/
// proposedmodes/gcm/gcm-revised-spec.pdf

It seems like the document is "The Galois/Counter Mode of Operation (GCM)" by David A. McGrew and John Viega from 2005 as found here. I am not sure whether to keep the old link or to find a trustworthy new URL.
@tniessen tniessen added the crypto Issues and PRs related to the crypto subsystem. label Dec 11, 2017
@sreepurnajasti
Copy link
Contributor

@tniessen Here is other URL which ref to same document.

tniessen added a commit to tniessen/node that referenced this issue Mar 25, 2018
@tniessen
test: update link according to NIST bibliography
0da49a2 
According to NIST SP 800 38D, this is the document the link orginally
pointed to.

Fixes: nodejs#17619
@tniessen tniessen mentioned this issue Mar 25, 2018
Closed
1 task
targos pushed a commit that referenced this issue Apr 2, 2018
@tniessen @targos
test: update link according to NIST bibliography
274eff5 
According to NIST SP 800 38D, this is the document the link orginally
pointed to.

Fixes: #17619

PR-URL: #19593
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 4, 2018
@tniessen @BethGriggs
test: update link according to NIST bibliography
0cbe813 
According to NIST SP 800 38D, this is the document the link orginally
pointed to.

Fixes: #17619

PR-URL: #19593
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: update link according to NIST bibliography tniessen/node
2 participants
@tniessen @sreepurnajasti