Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type annotations for eventName in events API doc to {string|symbol} #17657

Closed
TimothyGu opened this issue Dec 13, 2017 · 2 comments
Closed

Change type annotations for eventName in events API doc to {string|symbol} #17657

TimothyGu opened this issue Dec 13, 2017 · 2 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@TimothyGu
Copy link
Member

  • Version: master
  • Platform: all
  • Subsystem: doc

Offshoot from #17440 (comment).
@TimothyGu TimothyGu added the doc Issues and PRs related to the documentations. label Dec 13, 2017
@TimothyGu TimothyGu mentioned this issue Dec 13, 2017
Closed
4 tasks
@cjihrig cjihrig added the good first issue Issues that are suitable for first-time contributors. label Dec 13, 2017
@aprilwebster
Copy link
Contributor

Mind if I take this one?

@TimothyGu
Copy link
Member Author

@aprilwebster Go ahead!

@aprilwebster aprilwebster mentioned this issue Dec 13, 2017
Closed
2 tasks
aprilwebster added a commit to aprilwebster/node that referenced this issue Dec 14, 2017
@aprilwebster
doc: change eventName type annotations
6dbe6d4 
Change type annotations for eventName in events API doc from {any} to {string|symbol} to be consistent with doc changes made in nodejs#17440.

Fixes: nodejs#17657
MylesBorins pushed a commit that referenced this issue Jan 8, 2018
@aprilwebster @MylesBorins
doc: change eventName type annotations
29600cb 
Change type annotations for eventName in events API doc
from {any} to {string|symbol}.

PR-URL: #17666
Fixes: #17657
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this issue Jan 9, 2018
@aprilwebster @MylesBorins
doc: change eventName type annotations
712848b 
Change type annotations for eventName in events API doc
from {any} to {string|symbol}.

PR-URL: #17666
Fixes: #17657
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TimothyGu @aprilwebster @cjihrig