Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: In the http2 session API, add an event that fires when a PING request frame is received #18514

Closed
murgatroid99 opened this issue Feb 1, 2018 · 0 comments
Closed

Request: In the http2 session API, add an event that fires when a PING request frame is received #18514

murgatroid99 opened this issue Feb 1, 2018 · 0 comments
Labels
feature request Issues that request new features to be added to Node.js. http2 Issues or PRs related to the http2 subsystem.

Comments

@murgatroid99
Copy link
Contributor

On the server in particular, I would like to be able to see incoming pings, and possibly take action based on their frequency. A per-session event seems like a good way to do that.
@starkwang starkwang added feature request Issues that request new features to be added to Node.js. http2 Issues or PRs related to the http2 subsystem. labels Feb 2, 2018
jasnell added a commit to jasnell/node that referenced this issue Sep 21, 2018
@jasnell
http2: add ping event
604453c 
Add a `Http2Session` event whenever a non-ack `PING` is received.

Fixes: nodejs#18514
@jasnell jasnell mentioned this issue Sep 21, 2018
Closed
4 tasks
targos pushed a commit that referenced this issue Sep 24, 2018
@jasnell @targos
http2: add ping event
8bf004b 
Add a `Http2Session` event whenever a non-ack `PING` is received.

Fixes: #18514

PR-URL: #23009
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
kjin pushed a commit to kjin/node that referenced this issue Oct 3, 2018
@jasnell @kjin
http2: add ping event
020cf09 
Add a `Http2Session` event whenever a non-ack `PING` is received.

Fixes: nodejs#18514

PR-URL: nodejs#23009
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
kjin pushed a commit to kjin/node that referenced this issue Oct 16, 2018
@jasnell @kjin
http2: add ping event
40a8814 
Add a `Http2Session` event whenever a non-ack `PING` is received.

Fixes: nodejs#18514

PR-URL: nodejs#23009
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
BethGriggs pushed a commit that referenced this issue Oct 17, 2018
@jasnell @BethGriggs
http2: add ping event
10576d6 
Add a `Http2Session` event whenever a non-ack `PING` is received.

Fixes: #18514

Backport-PR-URL: #22850
PR-URL: #23009
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murgatroid99 @starkwang