-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedding: static nodejs variables are not set to default #21653
Comments
As mentioned in nodejs/help#1367, this probably requires us to introduce a proper options parse/options management system. |
@addaleax Not sure, what sort of help is needed here. But it would be great, if you can say what needs to be done (looks like its going to be a long list though) and will see if I can provide some help on it. Thanks! |
@antoaravinth Yes, it’s not going to be a short thing – this probably takes a long time to fully figure out, and it’s mostly C++ work. I think the roadmap would look something like this:
I’m happy to help as well as I can, but yes, it’s going to be a bunch of work. |
Thanks @addaleax for the response. Looks interesting, but unfortunately, I don't have good grasp on C++, so I can't help on that part. If anything that needs to be done from JS side, sure I'm ready to help here 👍 |
Yeah, I’m sorry I only realized now that I should probably mentioned that this is a C++-heavy thing. :D |
@ryansaam There’s #22192, which you probably want to read for context. It should be quite a bit easier to do this properly now, but still requires some thought on the exact shape of the API. I think that, eventually, we want a number of changes to the public API:
(Also, ping @danbev in case you have any ideas here.) |
Embedder can initialize nodejs to run scripts few times with different arguments. But if arguments from old launch weren't restored to theirs default values, nodejs can launch wrong next time. This function allows to reset arguments, which was impossible for embedder without modifying nodejs source code. Fixes: nodejs#21653
Is there any work pending in this issue, i could work on this. |
@addaleax ... given that node_options exists now... is this done? |
Ping @addaleax ... :-) |
I use nodejs to run javascript code in my application. And I have found that after running script from code, script from file will not run. It is caused by unpredicted value of
eval_string
static variable, that was not set to nullptr at previous run, and bootstrap tries to run code instead of file. Also I think, some other static variables can interrupt running scripts too.The text was updated successfully, but these errors were encountered: