Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-cluster-shared-leak failure on windows #3956

Closed
Fishrock123 opened this issue Nov 21, 2015 · 5 comments
Closed

test-cluster-shared-leak failure on windows #3956

Fishrock123 opened this issue Nov 21, 2015 · 5 comments
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@Fishrock123
Copy link
Contributor

not ok 28 test-cluster-shared-leak.js
# events.js:142
# throw er; // Unhandled 'error' event
# ^
# 
# Error: write EPIPE
# at exports._errnoException (util.js:873:11)
# at ChildProcess.target._send (internal/child_process.js:607:18)
# at ChildProcess.target.send (internal/child_process.js:508:19)
# at sendHelper (cluster.js:701:8)
# at send (cluster.js:505:5)
# at cluster.js:480:7
# at SharedHandle.add (cluster.js:83:3)
# at queryServer (cluster.js:472:12)
# at Worker.onmessage (cluster.js:428:7)
# at ChildProcess.<anonymous> (cluster.js:715:8)

https://ci.nodejs.org/job/node-test-binary-windows/91/RUN_SUBSET=3,VS_VERSION=vs2015,label=win2012r2/tapTestReport/test.tap-28/

(Run against #3954, unrelated.)

cc @Trott

@Fishrock123 Fishrock123 added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Nov 21, 2015
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Nov 21, 2015
@Trott
Copy link
Member

Trott commented Nov 30, 2015

Failed again here:

https://ci.nodejs.org/job/node-test-binary-windows/176/RUN_SUBSET=3,VS_VERSION=vs2015,label=win2012r2/console

Definitely one to add to the flaky tests list...

@Trott
Copy link
Member

Trott commented Dec 5, 2015

Trott added a commit to Trott/io.js that referenced this issue Dec 5, 2015
test-cluster-shared-leak is flaky on Windows.

Ref: nodejs#3956
@Trott
Copy link
Member

Trott commented Dec 5, 2015

The degree of flakiness apparently depends on which machine you end up with. (There are slow ones and there are fast ones.) Check out the massively different results of these identical stress test runs. The only difference is likely which Windows host the test ended up getting assigned to.

@Trott
Copy link
Member

Trott commented Dec 5, 2015

Pinging @nodejs/build because someone with more knowledge of the build infrastructure might be able to provide some useful insight on the previous comment.

The parameters for the two stress tests are identical and they checkout the same commit hash for testing, but they have nearly opposite results. The first has no failures (as of this writing--it's only about halfway done) after thousands of runs while the second has just 7 successes and hundreds of failures as of this writing.

Possibilities that leap to mind for me:

  • The flakiness is related to memory, CPU, or other resource.
  • The flakiness is related to some other configuration difference on either the host or the network where the host resides.

I suspect the correct fix is still to rewrite the test to accommodate what the issue is, but it seems like it would be useful to know what the issue is.

@Trott
Copy link
Member

Trott commented Dec 6, 2015

Possible fix: #4173

Trott added a commit that referenced this issue Dec 6, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Trott added a commit to Trott/io.js that referenced this issue Dec 7, 2015
test-cluster-shared-leak.js was flaky because a worker can emit EPIPE.
This error event is expected.

Fixes: nodejs#3956
Trott added a commit that referenced this issue Dec 8, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Trott added a commit to Trott/io.js that referenced this issue Dec 8, 2015
test-cluster-shared-leak.js was flaky because a worker can emit EPIPE.
Wait for workers to be listening so that EPIPE does not happen.

Fixes: nodejs#3956
PR-URL: nodejs#4173
Trott added a commit to Trott/io.js that referenced this issue Dec 27, 2015
Refactor test-cluster-shared-leak.js to remove flakiness on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4173
Trott added a commit to Trott/io.js that referenced this issue Dec 29, 2015
Swallow EPIPE as there is it is expected to come up from time to time.
This does not invalidate the test.

Fixes: nodejs#3956
PR-URL: nodejs#4173
Trott added a commit that referenced this issue Dec 29, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@Trott Trott closed this as completed Jan 1, 2016
@Trott Trott reopened this Jan 1, 2016
Trott added a commit to Trott/io.js that referenced this issue Jan 3, 2016
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
@Trott Trott closed this as completed in 063c9f6 Jan 4, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue Jan 6, 2016
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 28, 2016
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: #3956
PR-URL: #4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Feb 11, 2016
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: #3956
PR-URL: #4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this issue Feb 11, 2016
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this issue Feb 15, 2016
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
test-cluster-shared-leak is flaky on Windows.

Refs: nodejs#3956

PR-URL: nodejs#4162
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
Wait for worker2 to come online before doing anything that might result
in an EPIPE. Fixes flakiness of test on Windows.

Fixes: nodejs#3956
PR-URL: nodejs#4510
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell<jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

3 participants