worker: add function to get address of current isolate #43810
Comments
kvakil
added
the
feature request
|
(If it's not obvious from the issue description; I'm happy to make a PR with an implementation & tests if such a patch would be welcome.) |
|
Sounds reasonable to me, go for it. An alternative approach would be to scan the command line for flags and when they're present make node print the relevant information (thread id?) Neither approach seems strictly superior, so 🤷 |
This change adds two functions:
1. `require('worker_threads').getIsolateAddress()`: gets the address of
the isolate executing currently.
2. `worker.getIsolateAddress()`: gets the address of the isolate
corresponding to the worker.
Fixes: nodejs#43810
This change adds an experimental function `v8.getIsolateAddress()`, which returns the address of the currently executing isolate. It is intended to be used by application developers to correlate the output of `--trace_gc` with application-level log lines. Fixes: nodejs#43810
This change adds an experimental function `v8.getIsolateAddress()`, which returns the address of the currently executing isolate. It is intended to be used by application developers to correlate the output of `--trace_gc` with application-level log lines. Fixes: nodejs#43810
This change adds an experimental function `v8.getIsolateAddress()`, which returns the address of the currently executing isolate. It is intended to be used by application developers to correlate the output of `--trace_gc` with application-level log lines. Fixes: nodejs#43810
This change adds an experimental getter `v8.isolateAddress`, which returns the address of the currently executing isolate. It is intended to be used by application developers to correlate the output of `--trace_gc` with application-level log lines. Fixes: nodejs#43810
|
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment. For more information on how the project manages feature requests, please consult the feature request management document. |
|
There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment. For more information on how the project manages feature requests, please consult the feature request management document. |
What is the problem this feature will solve?
When running NodeJS with
--trace-gc(or--trace-gc-nvp/--trace-gc-verbose), you get a line which looks like this:The first number
1847is the PID of the NodeJS process, and the second hexnumber
0x5dad670is the address of the NodeJS isolate.Unfortunately, when running with worker threads, multiple isolates exist, and
so it can be difficult to correlate application-level logging with the output
of
--trace-gc.What is the feature you are proposing to solve the problem?
Add a new function to
worker_threads(orv8?) which returns the address ofthe current NodeJS isolate as a string. This way application developers can
correlate structured log lines with these GC trace lines.
What alternatives have you considered?
Per #42346, trace-gc is a "Tier 1" tool, and this issue makes it
significantly less useful with worker threads. At $WORK we have a native
addon which does this currently, but I think it's not unreasonable for
this to be in core NodeJS?
Anyway, I defer to the wisdom of the crowds.
The text was updated successfully, but these errors were encountered: