test_runner: it.skip and it.todo are not working as expected in the reporter

[ErickWendel]

Version

v19.8.1

Platform

Darwin MacBook-Pro-4 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:19:52 PDT 2022; root:xnu-8020.140.49~2/RELEASE_ARM64_T6000 arm64

Subsystem

No response

What steps will reproduce the bug?

import { describe, it } from 'node:test'
import { deepEqual } from 'node:assert'
describe('My test suite', () => {
  it.todo('should be a todo test')
  it.skip('should be a skip test')
  it('should assert a test', () => {
    deepEqual(0, 0)
  })
})

node --test index.test.mjs
▶ My test suite
  ✔ should be a todo test (0.188958ms)
  ✔ should be a skip test (0.034834ms)
  ✔ should assert a test (0.58775ms)
▶ My test suite (1.569917ms)

ℹ tests 1
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 49.43075

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

The test output should have
ℹ tests 3
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 1
ℹ todo 1

and the log should have different icons for each one:
📓 should be a todo test (0.188958ms)
➖ should be a skip test (0.034834ms)
✔ should assert a test (0.58775ms)
▶ My test suite (1.569917ms)

What do you see instead?

ℹ tests 1
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0

Additional information

@nodejs/test_runner

[ErickWendel]

it seems to be solved while building from the source. Closing now

[cjihrig]

I don't think it's completely fixed. There seems to at least be at least one discrepancy when running with --test vs. without it:

Without --test:

﹣ should be a skip test (0.367292ms) # SKIP

With --test:

 ✔ should be a skip test (0.350333ms)

[benjamingr]

Reopening per Colin's comment

[ErickWendel]

Perfect! Finally found something to work on 🤣

[ErickWendel]

OMG, this week is crazy busy here! Gonna go back to it on the weekend!

[cjihrig]

@MoLow will this be fixed by #47867? If so, let's link the issues so they autoclose on merge.

[MoLow]

indeed