Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 test failure when tests run from Node tree #4957

Closed
mhdawson opened this issue Jan 29, 2016 · 4 comments
Closed

V8 test failure when tests run from Node tree #4957

mhdawson opened this issue Jan 29, 2016 · 4 comments
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@mhdawson
Copy link
Member

There is work to add the ability to run v8 tests from the Node tree in #4704.

Early runs https://ci.nodejs.org/job/mdawson-RunV8TestsInNode/11/consoleFull show one test failure which is as follows:

[05:42|%  37|+ 8903|-   0]: mjsunit/regress/regress-crbug-514081 

=== mjsunit/regress/regress-crbug-514081 ===
Command: /home/iojs/build/workspace/mdawson-RunV8TestsInNode/node/deps/v8/out/x64.release/d8 --test --random-seed=-2038310014 --nohard-abort --nodead-code-elimination --nofold-constants /home/iojs/build/workspace/mdawson-RunV8TestsInNode/node/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/mdawson-RunV8TestsInNode/node/deps/v8/test/mjsunit/regress/regress-crbug-514081.js
exit code: -9
--- CRASHED ---
@mhdawson mhdawson added the v8 engine Issues and PRs related to the V8 dependency. label Jan 29, 2016
@bnoordhuis
Copy link
Member

The exit code suggests d8 was terminated by a SIGKILL. That normally means the test runner killed it after a timeout but you would expect to see --- TIMEOUT --- in that case.

Nice work, by the way!

@mhdawson
Copy link
Member Author

This run would indicate the issue is memory related as it passes on machines with 8g and fails on the ones with 4G and 2G https://ci.nodejs.org/job/node-test-commit-v8-linux-mdawson/14/

@mhdawson
Copy link
Member Author

mhdawson commented Mar 1, 2016

It does seem to consistently fail on machines with 2 and 4 G and pass on machines with 8g so I believe it is memory related. Looking at the test shows it is trying to allocate a really big array

var ab = new ArrayBuffer(2147483648);

@mhdawson
Copy link
Member Author

mhdawson commented Mar 9, 2016

Since this is almost certainly just related to available memory going to close and we'll make sure we run the tests on machines with 8G or more.

@mhdawson mhdawson closed this as completed Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

2 participants