test: run v8 tests #4704

exinfinitum · 2016-01-14T22:21:30Z

Ported by exinfinitum from a PR by jasnell:
see nodejs/node-v0.x-archive#14185

Allows the running of v8 tests on node's packaged v8 source code.

Note that the limited win32 support added by jasnell has NOT been ported,
and so these tests are currently UNIX ONLY.

Note that gclient depot tools (see https://commondatastorage.googleapis.com/
chrome-infra-docs/flat/depot_tools/docs/html/
depot_tools_tutorial.html#_setting_up) and subversion are required to run tests.

To perform tests, run the following commands:

make v8 DESTCPU=(ARCH)
make test-v8 DESTCPU=(ARCH)

where (ARCH) is your CPU architecture, e.g. x64, ia32.
DESTCPU MUST be specified for this to work properly.

Can also do tests on debug build by using "make test-v8 DESTCPU=(ARCH)
BUILDTYPE=Debug", or perform intl or benchmark tests via make test-v8-intl
or test-v8-benchmarks respectively.

Note that by default, quickcheck and TAP output are disabled, and i18n is
enabled. To activate these options, use options"QUICKCHECK=True" and
"ENABLE_V8_TAP=True" respectively. Use "DISABLE_V8_I18N" to disable i18n.

Any tests performed after changes to the packaged v8 file will require
recompiling of v8, which can be done using "make v8 DESTCPU=(ARCH)".

Finally, several additional files necessary for one of the v8 tests have been
added to the v8 folder.

Ported by exinfinitum from a PR by jasnell: see nodejs/node-v0.x-archive#14185 Allows the running of v8 tests on node's packaged v8 source code. Note that the limited win32 support added by jasnell has NOT been ported, and so these tests are currently UNIX ONLY. Note that gclient depot tools (see https://commondatastorage.googleapis.com/ chrome-infra-docs/flat/depot_tools/docs/html/ depot_tools_tutorial.html#_setting_up) and subversion are required to run tests. To perform tests, run the following commands: make v8 DESTCPU=(ARCH) make test-v8 DESTCPU=(ARCH) where (ARCH) is your CPU architecture, e.g. x64, ia32. DESTCPU MUST be specified for this to work properly. Can also do tests on debug build by using "make test-v8 DESTCPU=(ARCH) BUILDTYPE=Debug", or perform intl or benchmark tests via make test-v8-intl or test-v8-benchmarks respectively. Note that by default, quickcheck and TAP output are disabled, and i18n is enabled. To activate these options, use options"QUICKCHECK=True" and "ENABLE_V8_TAP=True" respectively. Use "DISABLE_V8_I18N" to disable i18n. Any tests performed after changes to the packaged v8 file will require recompiling of v8, which can be done using "make v8 DESTCPU=(ARCH)". Finally, two additional files necessary for one of the v8 tests have been added to the v8 folder.

mhdawson · 2016-01-14T22:31:09Z

CI run https://ci.nodejs.org/job/node-test-pull-request/

mhdawson · 2016-01-14T22:31:39Z

Validated on x64 were V8 tests ran/passed by following the instructions

jasnell · 2016-01-14T23:41:18Z

woohoo! LGTM

jasnell · 2016-01-14T23:42:16Z

Cautiously marking this as semver-minor for now. That may not be necessary. Ultimately, tho, while this should land in master, I'm not convinced it should backport to any of the stables.

Fishrock123 · 2016-01-15T04:47:10Z

How long do these tests take to run?

Also I'm we ignore v8's tests in tarballs, so adding them to make test would probably not be a good idea.

rvagg · 2016-01-15T04:48:51Z

/cc @nodejs/build
/ref nodejs/build#199

ofrobots · 2016-01-15T15:54:26Z

deps/v8/test/mjsunit/tools/tickprocessor-test-func-info.log

+tick,0x424284,0,0,0x480600,0,0x2aaaa5
+tick,0x42429f,0,0,0x480600,0,0x2aacb4
+tick,0x48063d,0,0,0x2d0f7c,0,0x2aaec6
+profiler,"end"


I am a little bit surprised why these output files are here.

I was rather surprised by that also when I went through this the first time. The v8 tests would not complete successfully without them. At the time I did not have the chance to investigate fully.

Node has a *.log rule in its top-level .gitignore that probably filtered them out before but these three files exist in upstream V8.

I'd asked the same question, and as @bnoordhuis confirms they are in the upstream v8 tree.

jbergstroem · 2016-01-17T22:16:32Z

is make v8 required? It looks like it's modifying the deps/v8 directory.

Replaced V8_BUILD_NO_I18N with V8_BUILD_OPTIONS to allow custom user-defined flags to be appended onto "make v8". Replaced "make" in Makefile to $(MAKE) to avoid issues when gmake != make. Added names of test v8 rules and v8 build rule to .PHONY. Removed changes to configure.

exinfinitum · 2016-01-27T23:06:38Z

@bnoordhuis @mhdawson @jasnell Updated.

exinfinitum · 2016-01-28T15:01:23Z

@jbergstroem: It is modifying the deps/v8 directory; the "make v8" is provided as a convenience so that a user can test the shipped version of v8 without having to move away from the node root directory.

jasnell · 2016-01-29T06:37:40Z

In the deps/v8 directory it is adding some log files that exist in the upstream V8 source but were filtered out of our git... so this isn't actually changing the V8 source at all.

mhdawson · 2016-01-29T21:01:58Z

Some initial runs here after installing svn on one of our build machines.

https://ci.nodejs.org/job/mdawson-RunV8TestsInNode/

To answer @Fishrock123 question it takes ~ 1 hr 3 min to run. The tests themselves take about 13 min. I am a bit surprised that it took that long to compile for all 3 runs as I expected cc cache to help on the 2 and 3rd run. This was on a 2 cpu machine and so we could cut down the time but using a larger machine as the compile/tests do run in parallel with -j X were X is the number of available CPUs.

Regardless I don't think this is something that will be added to the regular regression run, more something than can be run when somebody is making v8 specific changes and/or run nightly.

There currently is one failure which I captured here: #4957

mhdawson · 2016-02-02T14:59:57Z

I'm still tweaking the job to run the tests, but I think that's separate from this PR. I think that all of the comments have been addressed so lgtm from me.

@bnoordhuis @jbergstroem can you take another look and approve if you think its ready ?

exinfinitum · 2016-02-10T19:10:11Z

@bnoordhuis @mhdawson @jasnell @targos Updated. With the patch, "make v8 DESTCPU=x64" still works properly on my end.

mhdawson · 2016-02-10T20:00:50Z

Going to launch one more CI run, if it passes I'll land

mhdawson · 2016-02-10T21:23:05Z

With changes still ran as expected here https://ci.nodejs.org/job/mdawson-RunV8TestsInNode/19/consoleFull

Final CI run to make sure no external breakage https://ci.nodejs.org/job/node-test-pull-request/1630/

jasnell · 2016-02-10T22:21:20Z

Still LGTM if latest CI is green

Ported by exinfinitum from a PR by jasnell: see nodejs/node-v0.x-archive#14185 Allows the running of v8 tests on node's packaged v8 source code. Note that the limited win32 support added by jasnell has NOT been ported, and so these tests are currently UNIX ONLY. Note that gclient depot tools (see https://commondatastorage.googleapis.com/ chrome-infra-docs/flat/depot_tools/docs/html/ depot_tools_tutorial.html#_setting_up) and subversion are required to run tests. To perform tests, run the following commands: make v8 DESTCPU=(ARCH) make test-v8 DESTCPU=(ARCH) where (ARCH) is your CPU architecture, e.g. x64, ia32. DESTCPU MUST be specified for this to work properly. Can also do tests on debug build by using "make test-v8 DESTCPU=(ARCH) BUILDTYPE=Debug", or perform intl or benchmark tests via make test-v8-intl or test-v8-benchmarks respectively. Note that by default, quickcheck and TAP output are disabled, and i18n is enabled. To activate these options, use options"QUICKCHECK=True" and "ENABLE_V8_TAP=True" respectively. Use "DISABLE_V8_I18N" to disable i18n. Use V8_BUILD_OPTIONS to allow custom user-defined flags to be appended onto "make v8". Any tests performed after changes to the packaged v8 file will require recompiling of v8, which can be done using "make v8 DESTCPU=(ARCH)". Finally, two additional files necessary for one of the v8 tests have been added to the v8 folder. PR-URL: #4704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

mhdawson · 2016-02-11T18:14:59Z

landed as cd720f8 @exinfinitum thanks for all the hard work

jasnell · 2016-02-11T18:18:45Z

woohoo!

Ported by exinfinitum from a PR by jasnell: see nodejs/node-v0.x-archive#14185 Allows the running of v8 tests on node's packaged v8 source code. Note that the limited win32 support added by jasnell has NOT been ported, and so these tests are currently UNIX ONLY. Note that gclient depot tools (see https://commondatastorage.googleapis.com/ chrome-infra-docs/flat/depot_tools/docs/html/ depot_tools_tutorial.html#_setting_up) and subversion are required to run tests. To perform tests, run the following commands: make v8 DESTCPU=(ARCH) make test-v8 DESTCPU=(ARCH) where (ARCH) is your CPU architecture, e.g. x64, ia32. DESTCPU MUST be specified for this to work properly. Can also do tests on debug build by using "make test-v8 DESTCPU=(ARCH) BUILDTYPE=Debug", or perform intl or benchmark tests via make test-v8-intl or test-v8-benchmarks respectively. Note that by default, quickcheck and TAP output are disabled, and i18n is enabled. To activate these options, use options"QUICKCHECK=True" and "ENABLE_V8_TAP=True" respectively. Use "DISABLE_V8_I18N" to disable i18n. Use V8_BUILD_OPTIONS to allow custom user-defined flags to be appended onto "make v8". Any tests performed after changes to the packaged v8 file will require recompiling of v8, which can be done using "make v8 DESTCPU=(ARCH)". Finally, two additional files necessary for one of the v8 tests have been added to the v8 folder. PR-URL: #4704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

Ported by exinfinitum from a PR by jasnell: see nodejs/node-v0.x-archive#14185 Allows the running of v8 tests on node's packaged v8 source code. Note that the limited win32 support added by jasnell has NOT been ported, and so these tests are currently UNIX ONLY. Note that gclient depot tools (see https://commondatastorage.googleapis.com/ chrome-infra-docs/flat/depot_tools/docs/html/ depot_tools_tutorial.html#_setting_up) and subversion are required to run tests. To perform tests, run the following commands: make v8 DESTCPU=(ARCH) make test-v8 DESTCPU=(ARCH) where (ARCH) is your CPU architecture, e.g. x64, ia32. DESTCPU MUST be specified for this to work properly. Can also do tests on debug build by using "make test-v8 DESTCPU=(ARCH) BUILDTYPE=Debug", or perform intl or benchmark tests via make test-v8-intl or test-v8-benchmarks respectively. Note that by default, quickcheck and TAP output are disabled, and i18n is enabled. To activate these options, use options"QUICKCHECK=True" and "ENABLE_V8_TAP=True" respectively. Use "DISABLE_V8_I18N" to disable i18n. Use V8_BUILD_OPTIONS to allow custom user-defined flags to be appended onto "make v8". Any tests performed after changes to the packaged v8 file will require recompiling of v8, which can be done using "make v8 DESTCPU=(ARCH)". Finally, two additional files necessary for one of the v8 tests have been added to the v8 folder. PR-URL: nodejs#4704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

Ported by exinfinitum from a PR by jasnell: see nodejs/node-v0.x-archive#14185 Allows the running of v8 tests on node's packaged v8 source code. Note that the limited win32 support added by jasnell has NOT been ported, and so these tests are currently UNIX ONLY. Note that gclient depot tools (see https://commondatastorage.googleapis.com/ chrome-infra-docs/flat/depot_tools/docs/html/ depot_tools_tutorial.html#_setting_up) and subversion are required to run tests. To perform tests, run the following commands: make v8 DESTCPU=(ARCH) make test-v8 DESTCPU=(ARCH) where (ARCH) is your CPU architecture, e.g. x64, ia32. DESTCPU MUST be specified for this to work properly. Can also do tests on debug build by using "make test-v8 DESTCPU=(ARCH) BUILDTYPE=Debug", or perform intl or benchmark tests via make test-v8-intl or test-v8-benchmarks respectively. Note that by default, quickcheck and TAP output are disabled, and i18n is enabled. To activate these options, use options"QUICKCHECK=True" and "ENABLE_V8_TAP=True" respectively. Use "DISABLE_V8_I18N" to disable i18n. Use V8_BUILD_OPTIONS to allow custom user-defined flags to be appended onto "make v8". Any tests performed after changes to the packaged v8 file will require recompiling of v8, which can be done using "make v8 DESTCPU=(ARCH)". Finally, two additional files necessary for one of the v8 tests have been added to the v8 folder. PR-URL: #4704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * backport 9c927d0f01 from V8 upstream (Myles Borins) #7451 * cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post portem data to imrpove object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post portem data to imrpove object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **buffer**: * ignore negative allocation lengths (Anna Henningsen) #7562 * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994 * **npm**: * upgrade to 2.15.9 (Kat Marchán) #7692

Notable Changes: Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post mortem data to improve object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **buffer**: * ignore negative allocation lengths (Anna Henningsen) #7562 * **crypto**: * update root certificates (Ben Noordhuis) #7363 * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994 * **npm**: * upgrade to 2.15.9 (Kat Marchán) #7692

`vcbuild.bat test-v8` : Runs unit test from v8 repo `vcbuild.bat test-v8-intl` : Runs intl test from v8 repo `vcbuild.bat test-v8` : Runs benchmarks from v8 repo The runs needs https://www.chromium.org/developers/how-tos/install-depot-tools installed on the machine expects environment variable `DEPOT_TOOLS_PATH` to be set to the path. Set environment variable `DISABLE_V8_I18N` to disable i18n. PR-URL: nodejs#13992 Refs: nodejs#4704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

`vcbuild.bat test-v8` : Runs unit test from v8 repo `vcbuild.bat test-v8-intl` : Runs intl test from v8 repo `vcbuild.bat test-v8` : Runs benchmarks from v8 repo The runs needs https://www.chromium.org/developers/how-tos/install-depot-tools installed on the machine expects environment variable `DEPOT_TOOLS_PATH` to be set to the path. Set environment variable `DISABLE_V8_I18N` to disable i18n. PR-URL: #13992 Refs: #4704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

mhdawson self-assigned this Jan 14, 2016

mhdawson added test Issues and PRs related to the tests. relnotes v8 engine Issues and PRs related to the V8 dependency. and removed relnotes labels Jan 14, 2016

mhdawson mentioned this pull request Jan 14, 2016

Option to run V8 test suite nodejs/build#199

Closed

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 14, 2016

mhdawson mentioned this pull request Jan 15, 2016

V8 4.9 and trace_event DEPS change nodejs/build#304

Closed

ofrobots reviewed Jan 15, 2016
View reviewed changes

mhdawson mentioned this pull request Jan 29, 2016

V8 test failure when tests run from Node tree #4957

Closed

Added v8 build rule to PHONY (forgot for previous commit).

5be4b9b

mhdawson closed this Feb 11, 2016

MylesBorins mentioned this pull request Jun 28, 2016

[v4.x backport] test: run v8 tests from node tree #7451

Merged

2 tasks

MylesBorins mentioned this pull request Jul 12, 2016

Semver-Minor commits in v4.x-staging nodejs/Release#120

Closed

MylesBorins mentioned this pull request Jul 12, 2016

v4.5.0 proposal #7688

Merged

joaocgreis mentioned this pull request Oct 11, 2016

Looking for issue good for first contribution nodejs/build#495

Closed

piccoloaiutante mentioned this pull request Dec 21, 2016

doc: add minutes for build WG meeting 2016-12-20 nodejs/build#577

Merged

kunalspathak mentioned this pull request Jun 29, 2017

build,test: run v8 tests on windows #13992

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: run v8 tests #4704

test: run v8 tests #4704

exinfinitum commented Jan 14, 2016

mhdawson commented Jan 14, 2016

mhdawson commented Jan 14, 2016

jasnell commented Jan 14, 2016

jasnell commented Jan 14, 2016

Fishrock123 commented Jan 15, 2016

rvagg commented Jan 15, 2016

ofrobots Jan 15, 2016

jasnell Jan 15, 2016

bnoordhuis Jan 17, 2016

mhdawson Jan 29, 2016

jbergstroem commented Jan 17, 2016

exinfinitum commented Jan 27, 2016

exinfinitum commented Jan 28, 2016

jasnell commented Jan 29, 2016

mhdawson commented Jan 29, 2016

mhdawson commented Feb 2, 2016

exinfinitum commented Feb 10, 2016

mhdawson commented Feb 10, 2016

mhdawson commented Feb 10, 2016

jasnell commented Feb 10, 2016

mhdawson commented Feb 11, 2016

jasnell commented Feb 11, 2016

test: run v8 tests #4704

test: run v8 tests #4704

Conversation

exinfinitum commented Jan 14, 2016

mhdawson commented Jan 14, 2016

mhdawson commented Jan 14, 2016

jasnell commented Jan 14, 2016

jasnell commented Jan 14, 2016

Fishrock123 commented Jan 15, 2016

rvagg commented Jan 15, 2016

ofrobots Jan 15, 2016

Choose a reason for hiding this comment

jasnell Jan 15, 2016

Choose a reason for hiding this comment

bnoordhuis Jan 17, 2016

Choose a reason for hiding this comment

mhdawson Jan 29, 2016

Choose a reason for hiding this comment

jbergstroem commented Jan 17, 2016

exinfinitum commented Jan 27, 2016

exinfinitum commented Jan 28, 2016

jasnell commented Jan 29, 2016

mhdawson commented Jan 29, 2016

mhdawson commented Feb 2, 2016

exinfinitum commented Feb 10, 2016

mhdawson commented Feb 10, 2016

mhdawson commented Feb 10, 2016

jasnell commented Feb 10, 2016

mhdawson commented Feb 11, 2016

jasnell commented Feb 11, 2016