doc: add minutes for build WG meeting 2016-12-20 #577
Conversation
|
Just finished to listen the recorded version. I will come back for sure @jbergstroem and thanks for the right pronunciation of my name :-). @joaocgreis in issue #495 the other thing good for first contribution that you mentioned were:
What do you think is the best to go on? |
|
@piccoloaiutante It's up to you, which one do you prefer? Since now you have some experience with ansible, there is a more complex task that you might also consider: adapt the current Windows ansible scripts to the new ansible scripts at https://github.com/jbergstroem/build/tree/feature/refactor-the-world/ansible . It would be great to find a way to include Windows there without using a |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
PR-URL: nodejs#577 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
@joaocgreis perfect i'll go on with the first point "Generating .rdp and/or .remmina files (I have a rough script for Remmina that can serve as a starting point)." |
|
@joaocgreis can you share with me your script for generating .remmina file? |
|
@piccoloaiutante Sorry for the delay, I was out the last few weeks. Here it is: https://gist.github.com/joaocgreis/208e87942cba416467490947d7385efa This is just a prototype that I made to get me through, feel free to improve! Developing this in Johan's branch would be great, even if you do not port our current Windows setup scripts. There is already ssh config file generation there, this would be the equivalent for Windows. Thanks a lot! |
|
Excellent @joaocgreis, thanks |
|
@joaocgreis I've started looking at your script and my ideal goal would be to arrive to write it as a plugin for Ansible like the one @jbergstroem has written for ssh (https://github.com/jbergstroem/build/blob/feature/refactor-the-world/ansible/plugins/library/ssh_config.py) and used here (https://github.com/jbergstroem/build/blob/feature/refactor-the-world/ansible/playbooks/write-ssh-config.yml). How does it sounds to you? |
|
@piccoloaiutante sounds great! Some ideas/issues come to my head:
|
|
@joaocgreis that's what i'm currently working on: |
|
@joaocgreis i've updated the gist with a working version of the plugin, with yaml file. It works and produces one remmina file per server. The only thing that I need before raising a PR is an example of encrypted server_list with certificate so I can be sure that the gpg decryption works smoothly. Here is an example of server list in yaml: test-example-win10-x64-1:
ip: node-win10.example.org
port: 55443
username: Administrator
password: password1111
test-example-win10-x64-2:
ip: node-win10-2.example.org
port: 55443
username: Administrator
password: password1111 |
|
@piccoloaiutante that's fantastic! You can use dotgpg to encrypt the file I sent you. Here are some instructions:
Let me know if this is not enough or if you have trouble setting it up. Feel free to take this to IRC or email if you prefer. |
|
@joaocgreis I've tested it and it worked with a dotgpg created file. I've opened a pr against @jbergstroem As next task I have: Is it still the next priority? We can discuss about in next WG meeting. |
|
@piccoloaiutante thanks for your PR, I'll take a look! The work to support v8 tests in Windows is still relevant, please go ahead if you'd like to take that one. |
|
I have started looking into |
|
Update: On my local machine, i see 7 failures. Do we ignore it? Who is the right contact to check this about? I am on 5.8-lkgr. [06:35|% 100|+ 27873|- 7]: Done |
|
cc @ofrobots , if it's better to open an issue let us know where. Thanks! |
|
@kunalspathak can you paste which tests failed? /cc @nodejs/v8 |
|
@joaocgreis Do you mind opening an issue on the V8 tracker? I don't have a Windows machine and it's easier for us to track progress if we have an issue. Thanks! 🙇 |
|
@ofrobots - I did a reset to my environment. I will share that failures with you as soon as I run into it again. |
|
@ofrobots - Here are the details of test failures. Command ran Test failures: |
doc: add minutes for build WG meeting 2016-12-20