simple/test-crypto-stream broken after openssl upgrade #7

rvagg · 2014-11-28T10:23:24Z

=== release test-crypto-stream ===
Path: simple/test-crypto-stream
assert.js:100
  throw new assert.AssertionError({
        ^
AssertionError: false == true
    at Decipheriv.end (/opt/node/test/simple/test-crypto-stream.js:74:5)
    at Decipheriv.<anonymous> (/opt/node/test/common.js:241:15)
    at Decipheriv.emit (events.js:131:20)
    at done (_stream_transform.js:192:19)
    at _stream_transform.js:133:9
    at Decipheriv.Cipher._flush (crypto.js:180:5)
    at Decipheriv.<anonymous> (_stream_transform.js:132:12)
    at Decipheriv.g (events.js:201:16)
    at Decipheriv.emit (events.js:106:17)
    at prefinish (_stream_writable.js:448:12)
Command: out/Release/node /opt/node/test/simple/test-crypto-stream.js

consistent across all platforms I believe. Assigning to @indutny

The text was updated successfully, but these errors were encountered:

indutny · 2014-11-28T10:43:08Z

Fixed by backporting nodejs/node-v0.x-archive@707cc25 in 4d7e893, thank you!

Closes nodejs#7

Currently when running the test without an internet connection there are two JavaScript test failures and one cctest. The cctest only fails on Mac as far as I know. (I've only tested using Mac and Linux thus far). This commit moves the two JavaScript tests to test/internet. The details for test_inspector_socket_server.cc: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost make[1]: *** [cctest] Segmentation fault: 11 make: *** [test] Error 2 lldb output: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost Process 63058 stopped * thread nodejs#1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 libsystem_info.dylib`_gai_simple: -> 0x7fff96d04384 <+87>: movw (%rdx), %ax 0x7fff96d04387 <+90>: movw %ax, -0x2a(%rbp) 0x7fff96d0438b <+94>: movq %r13, -0x38(%rbp) 0x7fff96d0438f <+98>: movq 0x18(%rbp), %rcx (lldb) bt * thread nodejs#1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 frame nodejs#1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo + 179 frame nodejs#2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255 frame nodejs#3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179 frame nodejs#4: 0x00000001017d8888 cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at getaddrinfo.c:102 frame nodejs#5: 0x00000001017d880e cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8, cb=0x0000000000000000, hostname="nodejs.org", service="0", hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192 frame nodejs#6: 0x000000010171f781 cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658) + 801 at inspector_socket_server.cc:398 frame nodejs#7: 0x00000001016ed590 cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0) + 288 at test_inspector_socket_server.cc:593 I'm not sure about the exact cause for this but when using a standalone c program to simulate this it seems like when the ai_flags `AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc line 394, the servname (the port in the FailsToBindToNodejsHost test) is expected to be a numeric port string to avoid looking it up in /etc/services. When the port is 0 as is it was before this commit the segment fault occurs but not if it is non-zero. Here is the example program I used to reproduce: int main(int argc, char *argv[]) { struct addrinfo hints, *info, *p; int res; memset(&hints, 0, sizeof(hints)); hints.ai_flags = AI_NUMERICSERV; hints.ai_socktype = SOCK_STREAM; // using "0" will segfault if there is no internet connection if ((res = getaddrinfo("nodejs.org", "0", &hints, &info)) != 0) { fprintf(stderr, "Error: %s, (%d)\n", gai_strerror(res), res); exit(1); } fprintf(stdout, "flags %d\n", info->ai_flags); fprintf(stdout, "family %d\n", info->ai_family); fprintf(stdout, "socktype %d\n", info->ai_socktype); fprintf(stdout, "protocol %d\n", info->ai_protocol); }

Currently when running the test without an internet connection there are two JavaScript test failures and one cctest. The cctest only fails on Mac as far as I know. (I've only tested using Mac and Linux thus far). This commit moves the two JavaScript tests to test/internet. The details for test_inspector_socket_server.cc: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost make[1]: *** [cctest] Segmentation fault: 11 make: *** [test] Error 2 lldb output: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost Process 63058 stopped * thread nodejs#1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 libsystem_info.dylib`_gai_simple: -> 0x7fff96d04384 <+87>: movw (%rdx), %ax 0x7fff96d04387 <+90>: movw %ax, -0x2a(%rbp) 0x7fff96d0438b <+94>: movq %r13, -0x38(%rbp) 0x7fff96d0438f <+98>: movq 0x18(%rbp), %rcx (lldb) bt * thread nodejs#1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 frame nodejs#1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo + 179 frame nodejs#2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255 frame nodejs#3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179 frame nodejs#4: 0x00000001017d8888 cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at getaddrinfo.c:102 frame nodejs#5: 0x00000001017d880e cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8, cb=0x0000000000000000, hostname="nodejs.org", service="0", hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192 frame nodejs#6: 0x000000010171f781 cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658) + 801 at inspector_socket_server.cc:398 frame nodejs#7: 0x00000001016ed590 cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0) + 288 at test_inspector_socket_server.cc:593 I'm not sure about the exact cause for this but when using a standalone c program to simulate this it seems like when the ai_flags `AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc line 394, the servname (the port in the FailsToBindToNodejsHost test) is expected to be a numeric port string to avoid looking it up in /etc/services. When the port is 0 as is it was before this commit the segment fault occurs but not if it is non-zero. PR-URL: nodejs#16255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Currently when running the test without an internet connection there are two JavaScript test failures and one cctest. The cctest only fails on Mac as far as I know. (I've only tested using Mac and Linux thus far). This commit moves the two JavaScript tests to test/internet. The details for test_inspector_socket_server.cc: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost make[1]: *** [cctest] Segmentation fault: 11 make: *** [test] Error 2 lldb output: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost Process 63058 stopped * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 libsystem_info.dylib`_gai_simple: -> 0x7fff96d04384 <+87>: movw (%rdx), %ax 0x7fff96d04387 <+90>: movw %ax, -0x2a(%rbp) 0x7fff96d0438b <+94>: movq %r13, -0x38(%rbp) 0x7fff96d0438f <+98>: movq 0x18(%rbp), %rcx (lldb) bt * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) * frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 frame #1: 0x00007fff96cfe98b libsystem_info.dylib`search_addrinfo + 179 frame #2: 0x00007fff96cfafef libsystem_info.dylib`si_addrinfo + 2255 frame #3: 0x00007fff96cfa67b libsystem_info.dylib`getaddrinfo + 179 frame #4: 0x00000001017d8888 cctest`uv__getaddrinfo_work(w=0x00007fff5fbfe210) + 72 at getaddrinfo.c:102 frame #5: 0x00000001017d880e cctest`uv_getaddrinfo(loop=0x000000010287cb80, req=0x00007fff5fbfe1c8, cb=0x0000000000000000, hostname="nodejs.org", service="0", hints=0x00007fff5fbfe268) + 734 at getaddrinfo.c:192 frame #6: 0x000000010171f781 cctest`node::inspector::InspectorSocketServer::Start(this=0x00007fff5fbfe658) + 801 at inspector_socket_server.cc:398 frame #7: 0x00000001016ed590 cctest`InspectorSocketServerTest_FailsToBindToNodejsHost_Test::TestBody(this=0x0000000105001fd0) + 288 at test_inspector_socket_server.cc:593 I'm not sure about the exact cause for this but when using a standalone c program to simulate this it seems like when the ai_flags `AI_NUMERICSERV` is set, which is done in inspector_socket_server.cc line 394, the servname (the port in the FailsToBindToNodejsHost test) is expected to be a numeric port string to avoid looking it up in /etc/services. When the port is 0 as is it was before this commit the segment fault occurs but not if it is non-zero. PR-URL: #16255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

lint

rvagg assigned indutny Nov 28, 2014

indutny closed this as completed Nov 28, 2014

kvic-z mentioned this issue Oct 27, 2015

compile error ,target=arm7 #3224

Closed

jianpingw mentioned this issue Dec 13, 2015

node js 5.2.0 segmentation fault after console.log #4261

Closed

dmitryame mentioned this issue Mar 10, 2016

Abort trap: 6 #5646

Closed

rupamkhaitan mentioned this issue Jun 27, 2016

trap invalid opcode ip:fea6f9 #3898

Closed

jeroenvollenbrock mentioned this issue Jul 11, 2016

v8 GC crash on node 4.4.7 #7654

Closed

mhhf mentioned this issue Aug 24, 2016

Assertion failed ../deps/uv/src/unix/stream.c, line 1563 #8258

Closed

imyller mentioned this issue Sep 3, 2016

https.request failed for certain URL after first visting #8368

Closed

minervapanda pushed a commit to minervapanda/node that referenced this issue Oct 9, 2016

Mark project as licensed under Apache-2

163e4ac

Closes nodejs#7

rdkgit mentioned this issue Nov 11, 2016

SSL core dump in v6.9.1 #9551

Closed

shyhpei mentioned this issue Feb 3, 2017

segmentation fault at v8::internal::StoreBuffer::EnsureSpace () #11156

Closed

sxa mentioned this issue Mar 16, 2017

npm --version segfaults on v7.7.3 linux ppc64 (BE) only ON RHEL 7 #11882

Closed

kisondu mentioned this issue Jul 18, 2017

v8::internal::JSReceiver::DefineOwnProperty exception cause a crash #14335

Closed

myitcv mentioned this issue Aug 1, 2017

Segfault in v8.2.1 #14567

Closed

lolobug mentioned this issue Oct 31, 2018

fatal v8 error:Entering the V8 API without proper locking in place #23997

Closed

dansmolik mentioned this issue Jul 31, 2019

SAMA5D3 and buildroot carsh with Illegal instruction with hardfloat #28906

Closed

lomaster1 mentioned this issue Feb 6, 2020

Http2 Segmentation fault #29902

Closed

FlyGoat mentioned this issue Feb 26, 2020

crash on mipsel64 from v12.x #31118

Closed

Sebmaster mentioned this issue Mar 3, 2020

Segfault in v12.13.1 during GC #30875

Closed

This was referenced Mar 18, 2020

Revert "build: add asan check in Github action" #32324

Closed

Small memory leaks on EnvironmentTest.InspectorMultipleEmbeddedEnvironments #32415

Closed

rocketraman mentioned this issue Mar 26, 2020

Segmentation fault of node 10.8.0 x64 on Fedora 27 when running from PATH #22319

Closed

adamvy mentioned this issue Apr 13, 2020

"".localeCompare("\u0000") return -1, should it be 0? #32819

Closed

zyscoder mentioned this issue Apr 14, 2020

Instrumenting nodejs with AddressSanitizer fails resulting of memory leaks #32835

Closed

jiripospisil mentioned this issue Apr 27, 2020

async_hooks Segmentation fault #33090

Closed

tqchen mentioned this issue Apr 30, 2020

[BUG] Segfault on combo of global ctors, ostream, wasi #33175

Closed

codebytere mentioned this issue May 7, 2020

n-api segfault in v8impl::Reference::FinalizeCallback #33283

Closed

ofthesun9 mentioned this issue May 14, 2020

Cannot use node on Raspberry Pi Ubuntu #33244

Closed

mancasg mentioned this issue Jun 6, 2020

async_hooks: after hook called twice in case of uncaught exception #33771

Closed

frutiger mentioned this issue Jun 9, 2020

Segfault Creating Node Environments in v12.16.2 #33800

Closed

wmertens mentioned this issue Jun 19, 2020

uv__io_stop: Assertion `loop->watchers[w->fd] == w' failed. #33966

Closed

TimWolla mentioned this issue Feb 2, 2020

Segmentation fault in v8::internal::compiler::(anonymous namespace)::MayAlias (10.15.2 from Debian Buster) #31484

Closed

matthiaskrgr mentioned this issue Jun 26, 2020

make test: use after free: parallel/test-cli-node-options #21383

Open

hashseed mentioned this issue Jun 26, 2020

ThreadSanitizer: data race at PlatformWorkerThread::trace_event_unique_atomic35 #26100

Closed

addaleax mentioned this issue Jun 28, 2020

There appears to be a bug with the http2 header decoding #28632

Open

KungFuJesus mentioned this issue Jul 10, 2020

build 12.13.0 on mips64el segfault around mksnapshot #30304

Closed

gengjiawen mentioned this issue Aug 12, 2020

N-API reference management leaks memory #34731

Closed

Flarna mentioned this issue Aug 14, 2020

[v12.x backport] deps: V8: cherry-pick eec10a2fd8fa and #34008 #34776

Closed

FlorSanders mentioned this issue Aug 19, 2020

Raspberry Pi OS, malloc() when running script #34828

Closed

silverwind mentioned this issue Aug 20, 2020

https/http2: random crashes on macOS with simple server #34854

Closed

dislon mentioned this issue Sep 4, 2020

Debugger crashes with assertion failure while using Chrome DevTools and remote debug #17259

Open

tnodejs mentioned this issue Mar 25, 2021

use node 12.9.0 cause carsh problem #37902

Closed

cemkeylan mentioned this issue Jun 19, 2022

File name too long for ustar when creating a tarball of the nodejs installation nodejs/corepack#130

Closed

mhdawson mentioned this issue Sep 26, 2022

node-api: generalize finalizer second pass callback #44141

Closed

khagankhan mentioned this issue Oct 13, 2023

Use of Uninitialized Memory Detected in bytecode_builtins_list_generator by MemorySanitizer #50171

Closed

lemire added a commit to lemire/node that referenced this issue Mar 26, 2024

Merge pull request nodejs#7 from lemire/simplify-fs

c492c0d

lint

Megoy-Tambayan mentioned this issue May 13, 2024

[Snyk] Security upgrade rollup-plugin-typescript2 from 0.20.1 to 0.22.0 Megoy-Tambayan/node#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

simple/test-crypto-stream broken after openssl upgrade #7

simple/test-crypto-stream broken after openssl upgrade #7

rvagg commented Nov 28, 2014

indutny commented Nov 28, 2014

simple/test-crypto-stream broken after openssl upgrade #7

simple/test-crypto-stream broken after openssl upgrade #7

Comments

rvagg commented Nov 28, 2014

indutny commented Nov 28, 2014