Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The README is oriented towards Node #73

Closed
joshhartigan opened this issue Dec 4, 2014 · 7 comments
Closed

The README is oriented towards Node #73

joshhartigan opened this issue Dec 4, 2014 · 7 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@joshhartigan
Copy link

Although it is a reasonably small file, the project's readme is the central core of all the project's documentation, but it still uses documentation from Node.js. Some examples:

image 1
image 2

I'd suggest that a change is made to the readme so that it has more of a belonging to iojs, even if 'proper' documentation hasn't been written yet.
@SomeoneWeird
Copy link
Member

When #71 is merged then the latter should be changed.

@imjacobclark
Copy link

I have also submitted a PR for the former screenshot you submitted for newcomer resources; See #80.

@caineio
Copy link

caineio commented Dec 8, 2014

Hello!

I am pleased to see your valuable contribution to this project. Would you
please mind answering a couple of questions to help me classify this submission
and/or gather required information for the core team members?

Questions:

  1. Issue-only Does this issue happen in core, or in some user-space
    module from npm or other source? Please ensure that the test case
    that reproduces this problem is not using any external dependencies.
    If the error is not reproducible with just core modules - it is most
    likely not a io.js problem. Expected: yes
  2. Which part of core do you think it might be related to?
    One of: debugger, http, assert, buffer, child_process, cluster, crypto, dgram, dns, domain, events, fs, http, https, module, net, os, path, querystring, readline, repl, smalloc, stream, timers, tls, url, util, vm, zlib, c++, docs, other (label)
  3. Which versions of io.js do you think are affected by this?
    One of: v0.10, v0.12, v1.0.0 (label)

Please provide the answers in an ordered list like this:

  1. Answer for the first question
  2. Answer for the second question
  3. ...

Note that I am just a bot with a limited human-reply parsing abilities,
so please be very careful with numbers and don't skip the questions!

In case of success I will say: ...summoning the core team devs!.

In case of validation problem I will say: Sorry, but something is not right here:.

Truly yours,
Caine.

Responsibilities

  1. indutny: crypto, tls, https, child_process, c++
  2. trevnorris: buffer, http, https, smalloc
  3. bnoordhuis: http, cluster, child_process, dgram

@joshhartigan
Copy link
Author

  1. yes
  2. docs
  3. v0.12

@caineio
Copy link

caineio commented Dec 8, 2014

...summoning the core team devs!

@caineio caineio added doc Issues and PRs related to the documentations. v0.12 and removed need info labels Dec 8, 2014
@bnoordhuis
Copy link
Member

I think this has been addressed as of 6c36d19?

@joshhartigan
Copy link
Author

I'm relatively sure this is completely sorted out now.

bmeck pushed a commit to bmeck/node that referenced this issue Aug 11, 2015
@bnoordhuis
cluster: add handle ref/unref stubs in rr mode
fa98b97 
Add ref() and unref() stub methods to the faux handle in round-robin
mode.  Fixes the following TypeError when calling `server.unref()` in
the worker:

    net.js:1521
        this._handle.unref();
                     ^
    TypeError: this._handle.unref is not a function
        at Server.unref (net.js:1521:18)

No actual reference counting is implemented.  It would effectively be
a no-op because the control channel would still keep the worker alive.

Fixes: nodejs#73
PR-URL: nodejs#2274
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@ww9rivers ww9rivers mentioned this issue Dec 10, 2019
Closed
@umrigar umrigar mentioned this issue Dec 13, 2019
Closed
@joyeecheung joyeecheung mentioned this issue Feb 20, 2020
Closed
@snyk-bot snyk-bot mentioned this issue May 5, 2020
Open
@wmertens wmertens mentioned this issue Jun 19, 2020
Closed
@viyaha viyaha mentioned this issue Jul 10, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Sep 26, 2020
Open
@MadaraUchiha MadaraUchiha mentioned this issue Feb 25, 2021
Closed
@simov simov mentioned this issue Mar 6, 2021
Closed
targos added a commit to targos/node that referenced this issue Apr 17, 2021
@targos
deps: V8: cherry-pick ffde6ee0e4cd
92d9bb9 
Original commit message:

    Merged: Squashed multiple commits.

    Merged: [const-tracking] Mark const field as mutable when reconfiguring
    Revision: 7535b91f7cb22274de734d5da7d0324d8653d626

    Merged: [const-tracking] Fix incorrect DCHECK in MapUpdater
    Revision: f95db8916a731e6e5ccc0282616bc907ce06012f

    BUG=chromium:1161847,chromium:1185463,v8:9233
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    R=​ishell@chromium.org

    (cherry picked from commit 56518020bff4d0e8b82cff843c9f618c90084e42)

    Change-Id: I7f46a701646e1dd67a049b2aa4ac32d05b6885f3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748079
    Commit-Queue: Georg Neis <neis@chromium.org>
    Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Original-Commit-Position: refs/branch-heads/8.9@{nodejs#43}
    Cr-Original-Branched-From: 16b9bbbd581c25391981aa03180b76aa60463a3e-refs/heads/8.9.255@{#1}
    Cr-Original-Branched-From: d16a2a688498bd1c3e6a49edb25d8c4ca56232dc-refs/heads/master@{#72039}
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2794428
    Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
    Commit-Queue: Artem Sumaneev <asumaneev@google.com>
    Cr-Commit-Position: refs/branch-heads/8.6@{nodejs#73}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@ffde6ee
This was referenced Sep 13, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 13, 2021
Open
@solebox solebox mentioned this issue May 13, 2022
Open
@enterstudio enterstudio mentioned this issue May 14, 2022
Open
@UbuntuEvangelist UbuntuEvangelist mentioned this issue May 14, 2022
Open
@s4sc s4sc mentioned this issue May 14, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jan 8, 2023
Open
@Bhanditz Bhanditz mentioned this issue Nov 26, 2023
Open
@bumplzz69 bumplzz69 mentioned this issue Nov 26, 2023
Open
@RoeeOren RoeeOren mentioned this issue Nov 27, 2023
Open
@bsmoove247 bsmoove247 mentioned this issue Nov 27, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Nov 27, 2023
Open
@Matthelonianxl Matthelonianxl mentioned this issue Nov 27, 2023
Open
@sirinartk sirinartk mentioned this issue Nov 28, 2023
Open
@timzwit timzwit mentioned this issue Nov 28, 2023
Open
@vaibhavb vaibhavb mentioned this issue Nov 28, 2023
Open
@awaisab172 awaisab172 mentioned this issue Nov 29, 2023
Open
@ajesse11x ajesse11x mentioned this issue Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bnoordhuis @SomeoneWeird @imjacobclark @joshhartigan @caineio