Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/release.sh failed on macOS 10.12 #8822

Closed
evanlucas opened this issue Sep 28, 2016 · 0 comments
Closed

tools/release.sh failed on macOS 10.12 #8822

evanlucas opened this issue Sep 28, 2016 · 0 comments
Labels
tools Issues and PRs related to the tools directory.

Comments

@evanlucas
Copy link
Contributor

  • Version: master
  • Platform: macOS 10.12
  • Subsystem: tools

after signing a tag for a release, the release script does some magic to sign the SHASUMS256.txt file.

It calls git tag -v $version 2>&1 | grep 'key ID' | awk '{print $NF}'. (https://github.com/nodejs/node/blob/v6.7.0/tools/release.sh#L72)

The output of that command does not return anything on my machine using git v2.10.0. If I use the builtin git provided by apple (git v2.8.4), then the script works properly.

Here are the outputs from git tag -v v6.7.0:

With git v2.10.0:

$ git tag -v v6.7.0
object d87ad0ceea3f8ecf14b15cf95776fdbb277e0f07
type commit
tag v6.7.0
tagger Evan Lucas <evanlucas@me.com> 1475021173 -0500

2016-09-27 Node.js v6.7.0 (Current) Release
Git-EVTag-v0-SHA512: f36f72e58f83a6e254d4e43e0249b82db8b6f7f2bb9fd6b847b5f2e49843c6a47e0299363d5a6bebd46dc6af74ca8b02c06c932180be25252b12c5be37c8d8d9
gpg: Signature made Tue Sep 27 19:06:18 2016 CDT
gpg:                using RSA key B63B535A4C206CA9
gpg: Good signature from "Evan Lucas <evanlucas@me.com>" [ultimate]
gpg:                 aka "Evan Lucas <evanlucas@keybase.io>" [ultimate]

With git v2.8.4:

$ /usr/bin/git tag -v v6.7.0
object d87ad0ceea3f8ecf14b15cf95776fdbb277e0f07
type commit
tag v6.7.0
tagger Evan Lucas <evanlucas@me.com> 1475021173 -0500

2016-09-27 Node.js v6.7.0 (Current) Release
Git-EVTag-v0-SHA512: f36f72e58f83a6e254d4e43e0249b82db8b6f7f2bb9fd6b847b5f2e49843c6a47e0299363d5a6bebd46dc6af74ca8b02c06c932180be25252b12c5be37c8d8d9
gpg: Signature made Tue Sep 27 19:06:18 2016 CDT using RSA key ID 4C206CA9
gpg: Good signature from "Evan Lucas <evanlucas@me.com>" [ultimate]
gpg:                 aka "Evan Lucas <evanlucas@keybase.io>" [ultimate]

I am working on a proposed fix that works for both.

/cc @nodejs/release
@evanlucas evanlucas mentioned this issue Sep 28, 2016
Closed
1 task
@evanlucas evanlucas added the tools Issues and PRs related to the tools directory. label Sep 28, 2016
evanlucas added a commit to evanlucas/node that referenced this issue Oct 19, 2016
@evanlucas
tools: fix release script on macOS 10.12
5c6dce0 
Previously, we were relying on the output of gpg from git tag -v to
verify that the key selected by the releaser is the key that was used
to sign the tag. This output can change depending on the version of git
being used. Now, we just check that the output of git tag -v contains
the key selected.

Fixes: nodejs#8822
jasnell pushed a commit that referenced this issue Oct 20, 2016
@evanlucas @jasnell
tools: fix release script on macOS 10.12
3ab8be0 
Previously, we were relying on the output of gpg from git tag -v to
verify that the key selected by the releaser is the key that was used
to sign the tag. This output can change depending on the version of git
being used. Now, we just check that the output of git tag -v contains
the key selected.

Fixes: #8822
PR-URL: #8824
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this issue Nov 11, 2016
@evanlucas
tools: fix release script on macOS 10.12
e2bb2a2 
Previously, we were relying on the output of gpg from git tag -v to
verify that the key selected by the releaser is the key that was used
to sign the tag. This output can change depending on the version of git
being used. Now, we just check that the output of git tag -v contains
the key selected.

Fixes: #8822
PR-URL: #8824
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this issue Nov 11, 2016
@evanlucas
tools: fix release script on macOS 10.12
620cdc5 
Previously, we were relying on the output of gpg from git tag -v to
verify that the key selected by the releaser is the key that was used
to sign the tag. This output can change depending on the version of git
being used. Now, we just check that the output of git tag -v contains
the key selected.

Fixes: #8822
PR-URL: #8824
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evanlucas