Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: 'NA' appended to filename in compare.R output #9061

Closed
mscdex opened this issue Oct 12, 2016 · 3 comments
Closed

benchmark: 'NA' appended to filename in compare.R output #9061

mscdex opened this issue Oct 12, 2016 · 3 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented Oct 12, 2016

  • Version: master
  • Platform: n/a
  • Subsystem: benchmark

I'm not sure if I remember seeing this before, but I'm encountering an issue where the filename has NA appended directly after the filename (e.g. foo/bar.jsNA). I'm betting this has to do with no --set arguments being passed, so R is converting the empty string for that 'configuration' column to NA.

/cc @AndreasMadsen

@mscdex mscdex added the benchmark Issues and PRs related to the benchmark subsystem. label Oct 12, 2016
@AndreasMadsen
Copy link
Member

I haven't seen that before. Can you give me an example, what commands are you running?

@mscdex
Copy link
Contributor Author

mscdex commented Oct 12, 2016

Run any benchmark that does not have any configurable parameters, for example buffers/buffer-base64-decode.js:

$ node benchmark/compare.js --new ./node --old ./node --runs 10 --filter buffer-base64-decode buffers | Rscript benchmark/compare.R
                                   improvement significant   p.value
 buffers/buffer-base64-decode.jsNA     -0.50 %             0.2722066

@AndreasMadsen AndreasMadsen mentioned this issue Oct 12, 2016
2 tasks
@AndreasMadsen
Copy link
Member

@mscdex you are indeed correct. #9064 should fix it.

jasnell pushed a commit that referenced this issue Oct 17, 2016
When a benchmark did not contain any parameters the csv configuration
filed would be "". In R this is by default parsed as NA, causing NA in
the printout too.

Fixes: #9061
PR-URL: #9064
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants