Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: crypto.privateEncrypt() padding list needs update #9609

Closed
mscdex opened this issue Nov 14, 2016 · 1 comment
Closed

doc: crypto.privateEncrypt() padding list needs update #9609

mscdex opened this issue Nov 14, 2016 · 1 comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@mscdex
Copy link
Contributor

mscdex commented Nov 14, 2016

  • Version: all
  • Platform: n/a
  • Subsystem: doc

Currently crypto.privateEncypt() lists crypto.constants.RSA_PKCS1_OAEP_PADDING as a valid padding value, but it is actually only allowed for crypto.publicEncrypt() as far as encrypting goes. This value needs to simply be removed from that list in crypto.privateEncrypt()'s description.
@mscdex mscdex added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Nov 14, 2016
@mscdex mscdex mentioned this issue Nov 14, 2016
Closed
@JungMinu JungMinu mentioned this issue Nov 15, 2016
Closed
2 tasks
@JungMinu
Copy link
Member

PR: #9611

addaleax pushed a commit that referenced this issue Nov 22, 2016
@JungMinu @addaleax
doc: remove invalid padding from privateEncrypt
c99fb1e 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Dec 20, 2016
@JungMinu @MylesBorins
doc: remove invalid padding from privateEncrypt
c0d44df 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Dec 20, 2016
@JungMinu @MylesBorins
doc: remove invalid padding from privateEncrypt
ff7d856 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Dec 21, 2016
@JungMinu @MylesBorins
doc: remove invalid padding from privateEncrypt
d4adb3d 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Dec 21, 2016
@JungMinu @MylesBorins
doc: remove invalid padding from privateEncrypt
ba37972 
PR-URL: #9611
Fixes: #9609
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@jtousley jtousley mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: remove invalid padding from privateEncrypt
2 participants
@mscdex @JungMinu