test: test-file-write-stream3.js refactor #10035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
code-and-learn
mhdawson
requested changes
Dec 3, 2016
|
|
||
| options = { start: 10, | ||
| const options = { start: 10, | ||
| flags: 'r+' }; |
There was a problem hiding this comment.
Can you line this up so that start and flags line up like they did before (ie need to indent flags to align with new position of start)
|
|
||
| const data = '\u2026\u2026'; // 3 bytes * 2 = 6 bytes in UTF-8 | ||
|
|
||
| options = { start: 10, | ||
| const options = { start: 10, | ||
| flags: 'r+' }; |
There was a problem hiding this comment.
Can you line this up so that start and flags line up like they did before (ie need to indent flags to align with new position of start)
|
no problem, done |
cjihrig
approved these changes
Dec 5, 2016
jasnell
approved these changes
Dec 5, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 5, 2016
PR-URL: #10035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 18cf668. Thank you for the PR and for participating in the code-and-learn! |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
PR-URL: #10035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#10035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#10035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #10035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #10035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #10035 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Test refactor only
Description of change
Using const and strictEqual in test/parallel/test-file-write-stream3.js