Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test-crypto-stream.js - assert.equal -> assert.strictEqual #10065

Closed
wants to merge 1 commit into from
Closed

test: test-crypto-stream.js - assert.equal -> assert.strictEqual #10065

wants to merge 1 commit into from

Conversation

davidmarkclements
Copy link
Member

@davidmarkclements davidmarkclements commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, crypto

Description of change

changes assert.equal to assert.strictEqual to ensure specificity

edit: correct subsystem

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@davidmarkclements davidmarkclements changed the title assert.equal -> assert.strictEqual test-crypto-stream.js: assert.equal -> assert.strictEqual Dec 1, 2016
cjihrig
cjihrig approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the preferred style for the second change is, but if the linter is ok with it, LGTM.

@cjihrig
Copy link
Contributor

cjihrig commented Dec 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5054/

@davidmarkclements
Copy link
Member Author

oh regarding that - I forgot to mention, the linter made me split across the lines - otherwise it exceeds the column count

more than open to alternative suggestion for breaking up across lines (maybe put has into "expected" var?)

@cjihrig
Copy link
Contributor

cjihrig commented Dec 1, 2016

It passed linting, so I'm ok with it.

@julianduque julianduque added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. labels Dec 1, 2016
@davidmarkclements davidmarkclements changed the title test-crypto-stream.js: assert.equal -> assert.strictEqual test: test-crypto-stream.js - assert.equal -> assert.strictEqual Dec 1, 2016
test: assert.equal -> assert.strictEqual
8021261 
changes assert.equal to assert.strictEqual to ensure specificity
@addaleax
Copy link
Member

addaleax commented Dec 4, 2016

Landed in ea79a57, thanks!

@addaleax addaleax closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 4, 2016
@addaleax
test: assert.equal -> assert.strictEqual
ea79a57 
changes assert.equal to assert.strictEqual to ensure specificity

PR-URL: #10065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@addaleax
test: assert.equal -> assert.strictEqual
baa1acc 
changes assert.equal to assert.strictEqual to ensure specificity

PR-URL: #10065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@addaleax
test: assert.equal -> assert.strictEqual
bffbf68 
changes assert.equal to assert.strictEqual to ensure specificity

PR-URL: nodejs#10065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
test: assert.equal -> assert.strictEqual
a8dac07 
changes assert.equal to assert.strictEqual to ensure specificity

PR-URL: nodejs#10065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@MylesBorins
test: assert.equal -> assert.strictEqual
00f0864 
changes assert.equal to assert.strictEqual to ensure specificity

PR-URL: #10065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: assert.equal -> assert.strictEqual
fb73ded 
changes assert.equal to assert.strictEqual to ensure specificity

PR-URL: #10065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: assert.equal -> assert.strictEqual
b7b2fc1 
changes assert.equal to assert.strictEqual to ensure specificity

PR-URL: #10065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidmarkclements @cjihrig @addaleax @MylesBorins @julianduque @nodejs-github-bot