test: add known_issues test for #2734 #10322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
|
cc/ @fhinkel |
Fishrock123
reviewed
Dec 18, 2016
| const sandbox = Object.create(null, { | ||
| prop: { | ||
| get: function() { return 'foo';} | ||
| } |
There was a problem hiding this comment.
Do getter literals exists yet?
Can you do get prop () { ... }? If not you could drop the function and still use a object literal function e.g. get () { ... }.
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create
with the Object.create/defineProperty(-ies) syntax it seems to be the standard.... am I missing something?
There was a problem hiding this comment.
the above gives the same object as
const sandbox = {};
Object.defineProperty(sandbox, 'prop', {
get() {
return 'foo';
}
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tests
Description of change
A test addressing #2734
accessor properties get converted to data properties inside the vmis added to the known_issues directory.
It will be fixed with the 5.5 V8 API changes